[PATCH-SERIES qemu-server v2 0/3] fix #7743: api: disk import: avoid locking twice when importing from OVA or same VM

[Fiona Ebner <f.ebner@proxmox.com>]

Changes in v2:
* Better describe original issue in commit message.
* Add Dominik's R-b and Manuel's T-b.

When import_from_volid->() is called, the VM configuration of the
destination VM is already locked. In case the source volume belongs to
the same VM, there would be a second attempt to lock the config. In
particular, this also happens when importing from OVA, because the
source image is first extracted and belongs to the same VM.

The reason for bug #7743 is that the API call will lock before forking
a worker in the POST case, making a second lock attempt from the
different process fail. In the PUT case, the second lock attempt will
still succeed, because the lock is cached within the process in
PVE::Tools::lock_file_full(). So there also is a patch to change the
order of lock+fork around using the usual early+repeated checks
pattern.

qemu-server:

Fiona Ebner (3):
  api: disk import: remove unused wrongly named variable
  fix #7743: api: disk import: avoid locking twice when importing from
    OVA or same VM
  api: update vm: fork before locking

 src/PVE/API2/Qemu.pm | 780 ++++++++++++++++++++++---------------------
 1 file changed, 397 insertions(+), 383 deletions(-)


Summary over all repositories:
  1 files changed, 397 insertions(+), 383 deletions(-)

-- 
Generated by git-murpp 0.5.0