From: Fiona Ebner <f.ebner@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [PATCH qemu-server 1/3] api: disk import: remove unused wrongly named variable
Date: Mon, 29 Jun 2026 14:45:47 +0200 [thread overview]
Message-ID: <20260629124625.115457-2-f.ebner@proxmox.com> (raw)
In-Reply-To: <20260629124625.115457-1-f.ebner@proxmox.com>
The result from parse_volume_id() is the storage ID and the volume
name. Its input is the volume ID.
Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
---
src/PVE/API2/Qemu.pm | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/PVE/API2/Qemu.pm b/src/PVE/API2/Qemu.pm
index 9023c344..e575d36b 100644
--- a/src/PVE/API2/Qemu.pm
+++ b/src/PVE/API2/Qemu.pm
@@ -499,7 +499,7 @@ my sub create_disks : prototype($$$$$$$$$$$) {
$needs_creation = $live_import;
- my ($source_storage, $source_volid) = PVE::Storage::parse_volume_id($source, 1);
+ my ($source_storage) = PVE::Storage::parse_volume_id($source, 1);
if ($source_storage) { # PVE-managed volume
my ($vtype, $source_format) =
--
2.47.3
next prev parent reply other threads:[~2026-06-29 12:46 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-29 12:45 [PATCH-SERIES qemu-server 0/3] fix #7743: api: disk import: avoid locking twice when importing from OVA or same VM Fiona Ebner
2026-06-29 12:45 ` Fiona Ebner [this message]
2026-06-29 12:45 ` [PATCH qemu-server 2/3] " Fiona Ebner
2026-06-29 12:45 ` [PATCH qemu-server 3/3] api: update vm: fork before locking Fiona Ebner
2026-06-30 9:49 ` [PATCH-SERIES qemu-server 0/3] fix #7743: api: disk import: avoid locking twice when importing from OVA or same VM Manuel Federanko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260629124625.115457-2-f.ebner@proxmox.com \
--to=f.ebner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox