public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Dominik Csapak <d.csapak@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [PATCH manager] ui: qemu: boot order: warn of missing pxe support for ovmf
Date: Tue,  9 Jun 2026 14:08:50 +0200	[thread overview]
Message-ID: <20260609121033.2610172-1-d.csapak@proxmox.com> (raw)

OVMF can only use PXE/network boot when a virtual RNG device is added
for VMs, but this is not obvious from the UI or the error behavior.

Add a small warning to the boot order edit that says what is necessary.

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
I guess we don't want to add warnings for every little thing, but this
is very non-obvious when one needs its, since ovmf simply does not show
the network device, and adding an RNG device would not really come to
mind...

To be fair, it is written in the docs, but I think a short warning here
wouldn't hurt...

 www/manager6/qemu/BootOrderEdit.js | 23 +++++++++++++++++++++++
 1 file changed, 23 insertions(+)

diff --git a/www/manager6/qemu/BootOrderEdit.js b/www/manager6/qemu/BootOrderEdit.js
index 521a3d6e..c577c2c2 100644
--- a/www/manager6/qemu/BootOrderEdit.js
+++ b/www/manager6/qemu/BootOrderEdit.js
@@ -26,6 +26,7 @@ Ext.define('PVE.qemu.BootOrderPanel', {
             let grid = me.lookup('grid');
             let marker = me.lookup('marker');
             let emptyWarning = me.lookup('emptyWarning');
+            let rngPxeWarning = me.lookup('rngPxeWarning');
 
             marker.originalValue = undefined;
 
@@ -43,6 +44,19 @@ Ext.define('PVE.qemu.BootOrderPanel', {
                         view.inUpdate = false;
                         marker.checkDirty();
                         emptyWarning.setHidden(val !== '');
+
+                        let showRngPxeWarning = false;
+                        if (
+                            view.vmconfig?.bios?.toLowerCase().includes('ovmf') &&
+                            !view.vmconfig?.rng0 &&
+                            val?.includes('net')
+                        ) {
+                            showRngPxeWarning = true;
+                        }
+
+                        console.log('pxe?', showRngPxeWarning);
+                        rngPxeWarning.setHidden(!showRngPxeWarning);
+
                         grid.getView().refresh();
                     },
                 },
@@ -238,6 +252,15 @@ Ext.define('PVE.qemu.BootOrderPanel', {
             userCls: 'pmx-hint',
             value: gettext('Warning: No devices selected, the VM will probably not boot!'),
         },
+        {
+            xtype: 'displayfield',
+            reference: 'rngPxeWarning',
+            userCls: 'pmx-hint',
+            hidden: true,
+            value: gettext(
+                'Warning: PXE boot with OVMF only works when a Virtio RNG device is added!',
+            ),
+        },
         {
             // for dirty marking and 'reset' function
             xtype: 'field',
-- 
2.47.3





             reply	other threads:[~2026-06-09 12:10 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-09 12:08 Dominik Csapak [this message]
2026-06-09 12:12 ` superseded: [PATCH manager] ui: qemu: boot order: warn of missing pxe support for ovmf Dominik Csapak

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260609121033.2610172-1-d.csapak@proxmox.com \
    --to=d.csapak@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal