[PATCH docs v4 1/8] asciidoc-pve: allow linking sections with get_help_link

["Michael Köppl" <m.koeppl@proxmox.com>]

scan_extjs_file previously only scanned for occurrences of onlineHelp.
Linking to specific sections of the documentation with get_help_link was
not possible without an accompanying onlineHelp entry. Extend the regex
to also match get_help_link('blockid') calls.

biome may reformat function calls across multiple lines, so a scan which
reads one line at a time would miss those occurrences. Switch from
reading the file line by line to reading the whole file and matching
globally. In addition, tolerate an optional trailing comma after the
blockid argument. Line numbers for die/warn messages are reconstructed
from the match offset since $. is no longer meaningful when matching
against the full buffer.

Signed-off-by: Michael Köppl <m.koeppl@proxmox.com>
---
Feedback very much welcome. I ran into this problem when biome started
formatting the get_help_link function calls to multiple lines.
Alternatively, I could've added a `biome-ignore format: ...` to the
affected lines in pve-manager, but since it looks like we're not
ignoring the rules anywhere, I chose to adapt the scan function. I
tested this on both onlineHelp links and get_help_link links.

 scripts/asciidoc-pve.in | 19 ++++++++++---------
 1 file changed, 10 insertions(+), 9 deletions(-)

diff --git a/scripts/asciidoc-pve.in b/scripts/asciidoc-pve.in
index d42ddbe9..12fde424 100644
--- a/scripts/asciidoc-pve.in
+++ b/scripts/asciidoc-pve.in
@@ -463,16 +463,17 @@ sub scan_extjs_file {
 
     debug("scan-extjs $filename");
 
-    while (defined(my $line = <$fh>)) {
-        if ($line =~ m/\s+onlineHelp:\s*[\'\"]([^{}\[\]\'\"]+)[\'\"]/) {
-            my $blockid = $1;
-            my $link = $fileinfo->{blockid_target}->{default}->{$blockid};
-            if (!(defined($link) || defined($online_help_links->{$blockid}))) {
-                die "undefined blockid '$blockid' ($filename, line $.)\n" if !$allow_missing;
-                warn "ignoring undefined blockid '$blockid' ($filename, line $.)\n";
-            }
-            $res_data->{$blockid} = 1;
+    my $content = do { local $/; <$fh> };
+
+    while ($content =~ m/(?|\s+onlineHelp:\s*[\'\"]([^{}\[\]\'\"]+)[\'\"]|\bget_help_link\(\s*[\'\"]([^{}\[\]\'\"]+)[\'\"]\s*,?\s*\))/g) {
+        my $blockid = $1;
+        my $line_no = 1 + (substr($content, 0, $-[0]) =~ tr/\n//);
+        my $link = $fileinfo->{blockid_target}->{default}->{$blockid};
+        if (!(defined($link) || defined($online_help_links->{$blockid}))) {
+            die "undefined blockid '$blockid' ($filename, line $line_no)\n" if !$allow_missing;
+            warn "ignoring undefined blockid '$blockid' ($filename, line $line_no)\n";
         }
+        $res_data->{$blockid} = 1;
     }
 }
 
-- 
2.47.3