From: David Gonzalo Rodriguez <z80user@gmail.com>
To: pve-devel@lists.proxmox.com
Cc: David Gonzalo Rodriguez <z80user@gmail.com>
Subject: [PATCH] Signed-off-by: David Gonzalo Rodriguez <z80user@gmail.com>
Date: Wed, 27 May 2026 16:41:43 +0200 [thread overview]
Message-ID: <20260527144143.860766-1-z80user@gmail.com> (raw)
Fix the unit to show GiB on the user interface as default, it will show
"useSI" on the right units if is setup on the variable as true or false
The use a ternary expression here would produce incorrect results.
usually "useSI" is an object instead true or false.
---
pve-common | 1 +
src/Utils.js | 22 ++++++++++++++++++++--
2 files changed, 21 insertions(+), 2 deletions(-)
create mode 160000 pve-common
diff --git a/pve-common b/pve-common
new file mode 160000
index 0000000..971bb05
--- /dev/null
+++ b/pve-common
@@ -0,0 +1 @@
+Subproject commit 971bb05bf9ef4897083d8366e459a92b2b36c763
diff --git a/src/Utils.js b/src/Utils.js
index 7643316..71e027a 100644
--- a/src/Utils.js
+++ b/src/Utils.js
@@ -808,17 +808,35 @@ Ext.define('Proxmox.Utils', {
];
let order = 0;
let commaDigits = 2;
- const baseValue = useSI ? 1000 : 1024;
+
+// Do not use a ternary expression here and on the next check.
+// `useSI` may not exist and implicit truthy/falsy conversion
+// would produce incorrect results.
+ let baseValue = 1024;
+ if (useSI === true) {
+ baseValue = 1000;
+ }
+ if (useSI === false) {
+ baseValue = 1024;
+ }
while (size >= baseValue && order < unitsSI.length) {
size = size / baseValue;
order++;
}
- let unit = useSI ? unitsSI[order] : unitsIEC[order];
+ unit = unitsIEC[order];
+ if (useSI === true) {
+ unit = unitsSI[order];
+ }
+ if (useSI === false) {
+ unit = unitsIEC[order];
+ }
if (order === 0) {
commaDigits = 0;
}
return `${size.toFixed(commaDigits)} ${unit}`;
+
+
},
SizeUnits: {
--
2.47.3
next reply other threads:[~2026-05-27 15:32 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-27 14:41 David Gonzalo Rodriguez [this message]
2026-05-27 15:44 ` [PATCH] Signed-off-by: David Gonzalo Rodriguez <z80user@gmail.com> Stoiko Ivanov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260527144143.860766-1-z80user@gmail.com \
--to=z80user@gmail.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox