From: Arthur Bied-Charreton <a.bied-charreton@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [PATCH qemu-server v6 11/21] cpu models: add 'builtin' flag to CPU model list endpoint
Date: Mon, 18 May 2026 08:45:16 +0200 [thread overview]
Message-ID: <20260518064526.117067-12-a.bied-charreton@proxmox.com> (raw)
In-Reply-To: <20260518064526.117067-1-a.bied-charreton@proxmox.com>
The /nodes/{node}/capabilities/qemu/cpu endpoint returns both QEMU CPU
models and PVE-builtin models (e.g., x86-64-v2) under the same 'custom:
false' category, making them indistinguishable for API consumers.
This is needed so the UI can filter out builtin models from the
reported-model dropdown when creating custom CPU models, since builtin
models are a PVE abstraction and not valid QEMU reported-model values.
Signed-off-by: Arthur Bied-Charreton <a.bied-charreton@proxmox.com>
---
src/PVE/API2/Qemu/CPU.pm | 5 +++++
src/PVE/QemuServer/CPUConfig.pm | 3 +++
2 files changed, 8 insertions(+)
diff --git a/src/PVE/API2/Qemu/CPU.pm b/src/PVE/API2/Qemu/CPU.pm
index f8a7e11d..c929933f 100644
--- a/src/PVE/API2/Qemu/CPU.pm
+++ b/src/PVE/API2/Qemu/CPU.pm
@@ -50,6 +50,11 @@ __PACKAGE__->register_method({
. " model is selected. Vendor of"
. " 'reported-model' in case of custom models.",
},
+ builtin => {
+ type => 'boolean',
+ description => 'True if this is a builtin model',
+ optional => 1,
+ }
},
},
links => [{ rel => 'child', href => '{name}' }],
diff --git a/src/PVE/QemuServer/CPUConfig.pm b/src/PVE/QemuServer/CPUConfig.pm
index 8c3a5c49..0dc83081 100644
--- a/src/PVE/QemuServer/CPUConfig.pm
+++ b/src/PVE/QemuServer/CPUConfig.pm
@@ -566,6 +566,7 @@ sub get_cpu_models {
name => $default_model,
custom => 0,
vendor => $cpu_vendor_list->{$default_model},
+ builtin => 0,
};
}
@@ -578,6 +579,7 @@ sub get_cpu_models {
name => $model,
custom => 0,
vendor => $vendor,
+ builtin => 1,
};
}
@@ -593,6 +595,7 @@ sub get_cpu_models {
name => "custom-$custom_model",
custom => 1,
vendor => $vendor,
+ builtin => 0,
};
}
--
2.47.3
next prev parent reply other threads:[~2026-05-18 6:47 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-18 6:45 [PATCH manager/qemu-server v6 00/21] Add API and UI for custom CPU models Arthur Bied-Charreton
2026-05-18 6:45 ` [PATCH qemu-server v6 01/21] cpu config: rename CPU models config path variable Arthur Bied-Charreton
2026-05-18 6:45 ` [PATCH qemu-server v6 02/21] cpu flags: move cpu flags-related utilities to their own module Arthur Bied-Charreton
2026-05-18 6:45 ` [PATCH qemu-server v6 03/21] cpu flags: compare against JSON::true when querying supported flags Arthur Bied-Charreton
2026-05-18 6:45 ` [PATCH qemu-server v6 04/21] cpu flags: normalize CPU flags to QEMU's format Arthur Bied-Charreton
2026-05-18 6:45 ` [PATCH qemu-server v6 05/21] cpu flags: add helper querying CPU flags with nodes supporting them Arthur Bied-Charreton
2026-05-18 6:45 ` [PATCH qemu-server v6 06/21] cpu config: rename custom CPU model config loader Arthur Bied-Charreton
2026-05-18 6:45 ` [PATCH qemu-server v6 07/21] cpu config: add helpers to lock and write config Arthur Bied-Charreton
2026-05-18 6:45 ` [PATCH qemu-server v6 08/21] cpu: register standard option for CPU format Arthur Bied-Charreton
2026-05-18 6:45 ` [PATCH qemu-server v6 09/21] api: cpu flags: improve flags list returned by endpoint Arthur Bied-Charreton
2026-05-18 6:45 ` [PATCH qemu-server v6 10/21] custom cpu models: avoid redundant config load Arthur Bied-Charreton
2026-05-18 6:45 ` Arthur Bied-Charreton [this message]
2026-05-18 6:45 ` [PATCH pve-manager v6 12/21] cluster: reorder imports Arthur Bied-Charreton
2026-05-18 6:45 ` [PATCH pve-manager v6 13/21] cluster: makefile: reorder perl sources and align backslashes Arthur Bied-Charreton
2026-05-18 6:45 ` [PATCH pve-manager v6 14/21] api: add endpoint querying available CPU flags cluster-wide Arthur Bied-Charreton
2026-05-18 6:45 ` [PATCH pve-manager v6 15/21] api: add CRUD handlers for custom CPU models Arthur Bied-Charreton
2026-05-18 6:45 ` [PATCH pve-manager v6 16/21] ui: cpu model selector: allow filtering out custom and builtin models Arthur Bied-Charreton
2026-05-18 6:45 ` [PATCH pve-manager v6 17/21] ui: add basic custom CPU model editor Arthur Bied-Charreton
2026-05-18 6:45 ` [PATCH pve-manager v6 18/21] ui: cpu flags selector: add CPU flag editor for custom models Arthur Bied-Charreton
2026-05-18 6:45 ` [PATCH pve-manager v6 19/21] ui: cpu flags selector: allow filtering out flags supported on 0 nodes Arthur Bied-Charreton
2026-05-18 6:45 ` [PATCH pve-manager v6 20/21] ui: cpu flags selector: add search bar for large lists of flags Arthur Bied-Charreton
2026-05-18 6:45 ` [PATCH pve-manager v6 21/21] ui: group custom CPU with resource mappings Arthur Bied-Charreton
2026-05-18 8:00 ` [PATCH manager/qemu-server v6 00/21] Add API and UI for custom CPU models Thomas Lamprecht
2026-05-18 8:03 ` Arthur Bied-Charreton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260518064526.117067-12-a.bied-charreton@proxmox.com \
--to=a.bied-charreton@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox