From: Erik Fastermann <e.fastermann@proxmox.com>
To: pve-devel@lists.proxmox.com
Cc: Erik Fastermann <e.fastermann@proxmox.com>
Subject: [PATCH pve-manager v2] fix #6348: ui: bulk action: use options tag style
Date: Fri, 15 May 2026 14:08:27 +0200 [thread overview]
Message-ID: <20260515120827.141764-1-e.fastermann@proxmox.com> (raw)
Use the tag style configured in the options for the bulk action table.
This improves visual consistency and makes tagged resources easier to
identify at a glance.
Signed-off-by: Erik Fastermann <e.fastermann@proxmox.com>
---
changes since v1:
* use the tag style configured in the options menu
www/manager6/UIOptions.js | 14 +++++++++++---
www/manager6/dc/OptionView.js | 4 ++--
www/manager6/form/VMSelector.js | 2 ++
3 files changed, 15 insertions(+), 5 deletions(-)
diff --git a/www/manager6/UIOptions.js b/www/manager6/UIOptions.js
index 99b999b7..7f9583c2 100644
--- a/www/manager6/UIOptions.js
+++ b/www/manager6/UIOptions.js
@@ -60,12 +60,20 @@ Ext.define('PVE.UIOptions', {
let overrides = style?.['color-map'];
PVE.UIOptions.updateTagOverrides(PVE.UIOptions.parseTagOverrides(overrides ?? ''));
+ const tagStyle = PVE.UIOptions.tagStyleClass(style);
+
+ Ext.ComponentQuery.query('pveResourceTree')[0].setUserCls(tagStyle);
+ Ext.ComponentQuery.query('vmselector').forEach(component => {
+ component.setUserCls(tagStyle);
+ });
+ },
+
+ tagStyleClass: function (style) {
let shape = style?.shape ?? 'circle';
if (shape === '__default__') {
- style = 'circle';
+ shape = 'circle';
}
-
- Ext.ComponentQuery.query('pveResourceTree')[0].setUserCls(`proxmox-tags-${shape}`);
+ return `proxmox-tags-${shape}`;
},
tagTreeStyles: {
diff --git a/www/manager6/dc/OptionView.js b/www/manager6/dc/OptionView.js
index 7c8d3792..a19ba136 100644
--- a/www/manager6/dc/OptionView.js
+++ b/www/manager6/dc/OptionView.js
@@ -393,7 +393,7 @@ Ext.define('PVE.dc.OptionView', {
let colors = PVE.UIOptions.parseTagOverrides(value?.['color-map']);
let shape = value.shape;
let shapeText = PVE.UIOptions.tagTreeStyles[shape ?? '__default__'];
- let txt = Ext.String.format(gettext('Tree Shape: {0}'), shapeText);
+ let txt = Ext.String.format(gettext('Shape: {0}'), shapeText);
let orderText = PVE.UIOptions.tagOrderOptions[value.ordering ?? '__default__'];
txt += `, ${Ext.String.format(gettext('Ordering: {0}'), orderText)}`;
if (value['case-sensitive']) {
@@ -457,7 +457,7 @@ Ext.define('PVE.dc.OptionView', {
{
name: 'shape',
xtype: 'proxmoxComboGrid',
- fieldLabel: gettext('Tree Shape'),
+ fieldLabel: gettext('Shape'),
valueField: 'value',
displayField: 'display',
allowBlank: false,
diff --git a/www/manager6/form/VMSelector.js b/www/manager6/form/VMSelector.js
index 57aa73a7..f45c4db1 100644
--- a/www/manager6/form/VMSelector.js
+++ b/www/manager6/form/VMSelector.js
@@ -267,6 +267,8 @@ Ext.define('PVE.form.VMSelector', {
me.getSelectionModel().selectAll(false);
});
}
+
+ me.userCls = PVE.UIOptions.tagStyleClass(PVE.UIOptions.options['tag-style']);
},
});
--
2.47.3
reply other threads:[~2026-05-15 12:09 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260515120827.141764-1-e.fastermann@proxmox.com \
--to=e.fastermann@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox