From: Hannes Laimer <h.laimer@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [PATCH pve-manager v5 7/8] ui: sdn: add BGP fabric support
Date: Wed, 13 May 2026 20:42:12 +0200 [thread overview]
Message-ID: <20260513184213.506775-8-h.laimer@proxmox.com> (raw)
In-Reply-To: <20260513184213.506775-1-h.laimer@proxmox.com>
Register BGP as a fabric protocol in the UI. The fabric editor omits
the ASN field since each node must specify its own unique ASN for
eBGP unnumbered peering. The interface panel excludes the IP column
since BGP unnumbered interfaces have no IP addresses.
Signed-off-by: Hannes Laimer <h.laimer@proxmox.com>
---
www/manager6/Makefile | 3 +
www/manager6/sdn/FabricsView.js | 12 ++++
www/manager6/sdn/fabrics/FabricEdit.js | 12 +++-
www/manager6/sdn/fabrics/NodeEdit.js | 1 +
www/manager6/sdn/fabrics/bgp/FabricEdit.js | 70 +++++++++++++++++++
.../sdn/fabrics/bgp/InterfacePanel.js | 15 ++++
www/manager6/sdn/fabrics/bgp/NodeEdit.js | 23 ++++++
7 files changed, 133 insertions(+), 3 deletions(-)
create mode 100644 www/manager6/sdn/fabrics/bgp/FabricEdit.js
create mode 100644 www/manager6/sdn/fabrics/bgp/InterfacePanel.js
create mode 100644 www/manager6/sdn/fabrics/bgp/NodeEdit.js
diff --git a/www/manager6/Makefile b/www/manager6/Makefile
index b4ae1b3b..27f123d8 100644
--- a/www/manager6/Makefile
+++ b/www/manager6/Makefile
@@ -348,6 +348,9 @@ JSSRC= \
sdn/fabrics/wireguard/InterfacePanel.js \
sdn/fabrics/wireguard/NodeEdit.js \
sdn/fabrics/wireguard/FabricEdit.js \
+ sdn/fabrics/bgp/InterfacePanel.js \
+ sdn/fabrics/bgp/NodeEdit.js \
+ sdn/fabrics/bgp/FabricEdit.js \
storage/ContentView.js \
storage/BackupView.js \
storage/Base.js \
diff --git a/www/manager6/sdn/FabricsView.js b/www/manager6/sdn/FabricsView.js
index 7da1990d..9a802985 100644
--- a/www/manager6/sdn/FabricsView.js
+++ b/www/manager6/sdn/FabricsView.js
@@ -34,6 +34,7 @@ Ext.define('PVE.sdn.Fabric.View', {
openfabric: 'OpenFabric',
ospf: 'OSPF',
wireguard: 'WireGuard',
+ bgp: 'BGP',
};
const displayValue = PROTOCOL_DISPLAY_NAMES[value];
if (rec.data.state === undefined || rec.data.state === null) {
@@ -203,6 +204,10 @@ Ext.define('PVE.sdn.Fabric.View', {
text: 'WireGuard',
handler: 'addWireGuard',
},
+ {
+ text: 'BGP',
+ handler: 'addBgp',
+ },
],
},
addNodeButton,
@@ -282,6 +287,7 @@ Ext.define('PVE.sdn.Fabric.View', {
openfabric: 'PVE.sdn.Fabric.OpenFabric.Fabric.Edit',
ospf: 'PVE.sdn.Fabric.Ospf.Fabric.Edit',
wireguard: 'PVE.sdn.Fabric.WireGuard.Fabric.Edit',
+ bgp: 'PVE.sdn.Fabric.Bgp.Fabric.Edit',
};
return FABRIC_PANELS[protocol];
@@ -292,6 +298,7 @@ Ext.define('PVE.sdn.Fabric.View', {
openfabric: 'PVE.sdn.Fabric.OpenFabric.Node.Edit',
ospf: 'PVE.sdn.Fabric.Ospf.Node.Edit',
wireguard: 'PVE.sdn.Fabric.WireGuard.Node.Edit',
+ bgp: 'PVE.sdn.Fabric.Bgp.Node.Edit',
};
return NODE_PANELS[protocol];
@@ -312,6 +319,11 @@ Ext.define('PVE.sdn.Fabric.View', {
me.openFabricAddWindow('ospf');
},
+ addBgp: function () {
+ let me = this;
+ me.openFabricAddWindow('bgp');
+ },
+
openFabricAddWindow: function (protocol) {
let me = this;
diff --git a/www/manager6/sdn/fabrics/FabricEdit.js b/www/manager6/sdn/fabrics/FabricEdit.js
index 43a402a9..322a62c0 100644
--- a/www/manager6/sdn/fabrics/FabricEdit.js
+++ b/www/manager6/sdn/fabrics/FabricEdit.js
@@ -37,6 +37,7 @@ Ext.define('PVE.sdn.Fabric.Fabric.Edit', {
],
additionalItems: [],
+ additionalAdvancedItems: [],
additionalTabs: [],
initComponent: function () {
@@ -101,10 +102,15 @@ Ext.define('PVE.sdn.Fabric.Fabric.Edit', {
if (me.additionalTabs.length > 0) {
let items = [...me.items, ...me.additionalItems];
- let iPanel = Ext.create('Proxmox.panel.InputPanel', {
+ let panelConfig = {
title: gettext('Fabric'),
items,
- });
+ };
+ if (me.additionalAdvancedItems.length > 0) {
+ panelConfig.advancedItems = me.additionalAdvancedItems;
+ }
+
+ let iPanel = Ext.create('Proxmox.panel.InputPanel', panelConfig);
me.bodyPadding = 0;
@@ -116,7 +122,7 @@ Ext.define('PVE.sdn.Fabric.Fabric.Edit', {
},
];
} else {
- me.items.push(...me.additionalItems);
+ me.items.push(...me.additionalItems, ...me.additionalAdvancedItems);
}
me.callParent();
diff --git a/www/manager6/sdn/fabrics/NodeEdit.js b/www/manager6/sdn/fabrics/NodeEdit.js
index f2a32c7b..272915aa 100644
--- a/www/manager6/sdn/fabrics/NodeEdit.js
+++ b/www/manager6/sdn/fabrics/NodeEdit.js
@@ -260,6 +260,7 @@ Ext.define('PVE.sdn.Fabric.Node.Edit', {
openfabric: 'PVE.sdn.Fabric.OpenFabric.InterfacePanel',
ospf: 'PVE.sdn.Fabric.Ospf.InterfacePanel',
wireguard: 'PVE.sdn.Fabric.WireGuard.InterfacePanel',
+ bgp: 'PVE.sdn.Fabric.Bgp.InterfacePanel',
};
return INTERFACE_PANELS[protocol];
diff --git a/www/manager6/sdn/fabrics/bgp/FabricEdit.js b/www/manager6/sdn/fabrics/bgp/FabricEdit.js
new file mode 100644
index 00000000..40941b5a
--- /dev/null
+++ b/www/manager6/sdn/fabrics/bgp/FabricEdit.js
@@ -0,0 +1,70 @@
+Ext.define('PVE.sdn.Fabric.Bgp.Fabric.Edit', {
+ extend: 'PVE.sdn.Fabric.Fabric.Edit',
+
+ subject: 'BGP',
+ onlineHelp: 'pvesdn_bgp_fabric',
+
+ extraRequestParams: {
+ protocol: 'bgp',
+ },
+
+ additionalItems: [
+ {
+ xtype: 'proxmoxcheckbox',
+ fieldLabel: gettext('BFD'),
+ labelWidth: 120,
+ name: 'bfd',
+ uncheckedValue: 0,
+ defaultValue: 0,
+ },
+ {
+ xtype: 'pveSDNPrefixListSelector',
+ name: 'route_filter',
+ fieldLabel: gettext('Route Filter'),
+ labelWidth: 120,
+ emptyText: gettext('IP Prefixes'),
+ deleteEmpty: true,
+ skipEmptyText: true,
+ },
+ ],
+
+ additionalAdvancedItems: [
+ {
+ xtype: 'pveSDNRouteMapSelector',
+ name: 'route_map_in',
+ fieldLabel: gettext('Incoming Route Map'),
+ labelWidth: 120,
+ emptyText: gettext('Route Map'),
+ deleteEmpty: true,
+ skipEmptyText: true,
+ },
+ {
+ xtype: 'pveSDNRouteMapSelector',
+ name: 'route_map_out',
+ fieldLabel: gettext('Outgoing Route Map'),
+ labelWidth: 120,
+ emptyText: gettext('Route Map'),
+ deleteEmpty: true,
+ skipEmptyText: true,
+ },
+ ],
+
+ additionalTabs: [
+ {
+ xtype: 'inputpanel',
+ title: gettext('Route Redistribution'),
+ items: [
+ {
+ xtype: 'pveSDNRedistributionGrid',
+ name: 'redistribute',
+ sources: [
+ ['ospf', gettext('OSPF')],
+ ['connected', gettext('Connected')],
+ ['static', gettext('Static')],
+ ['kernel', gettext('Kernel')],
+ ],
+ },
+ ],
+ }
+ ],
+});
diff --git a/www/manager6/sdn/fabrics/bgp/InterfacePanel.js b/www/manager6/sdn/fabrics/bgp/InterfacePanel.js
new file mode 100644
index 00000000..c7ac7627
--- /dev/null
+++ b/www/manager6/sdn/fabrics/bgp/InterfacePanel.js
@@ -0,0 +1,15 @@
+Ext.define('PVE.sdn.Fabric.Bgp.InterfacePanel', {
+ extend: 'PVE.sdn.Fabric.InterfacePanel',
+
+ hasIpv6Support: false,
+
+ // BGP unnumbered interfaces have no IP - override commonColumns to
+ // exclude the IP column that the base class defines.
+ initComponent: function () {
+ let me = this;
+
+ me.commonColumns = me.commonColumns.filter((col) => col.dataIndex !== 'ip');
+
+ me.callParent();
+ },
+});
diff --git a/www/manager6/sdn/fabrics/bgp/NodeEdit.js b/www/manager6/sdn/fabrics/bgp/NodeEdit.js
new file mode 100644
index 00000000..1ad586df
--- /dev/null
+++ b/www/manager6/sdn/fabrics/bgp/NodeEdit.js
@@ -0,0 +1,23 @@
+Ext.define('PVE.sdn.Fabric.Bgp.Node.Edit', {
+ extend: 'PVE.sdn.Fabric.Node.Edit',
+ protocol: 'bgp',
+
+ extraRequestParams: {
+ protocol: 'bgp',
+ role: 'internal',
+ },
+
+ includeWireguardInterfaces: true,
+
+ additionalItems: [
+ {
+ xtype: 'proxmoxintegerfield',
+ fieldLabel: gettext('ASN'),
+ labelWidth: 120,
+ name: 'asn',
+ minValue: 1,
+ maxValue: 4294967295,
+ allowBlank: false,
+ },
+ ],
+});
--
2.47.3
next prev parent reply other threads:[~2026-05-13 18:42 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-13 18:42 [PATCH docs/manager/network/proxmox{-ve-rs,-perl-rs} v5 0/8] sdn: add BGP fabric Hannes Laimer
2026-05-13 18:42 ` [PATCH proxmox-ve-rs v5 1/8] sdn: fabric: add BGP protocol support Hannes Laimer
2026-05-13 18:42 ` [PATCH proxmox-perl-rs v5 2/8] sdn: fabrics: add BGP config generation Hannes Laimer
2026-05-13 18:42 ` [PATCH proxmox-perl-rs v5 3/8] sdn: fabrics: add BGP status endpoints Hannes Laimer
2026-05-13 18:42 ` [PATCH pve-network v5 4/8] sdn: fabrics: register bgp as a fabric protocol type Hannes Laimer
2026-05-13 18:42 ` [PATCH pve-network v5 5/8] sdn: evpn: support eBGP VTEPs over BGP fabric underlays Hannes Laimer
2026-05-13 18:42 ` [PATCH pve-network v5 6/8] test: evpn: add integration test for EVPN over BGP fabric Hannes Laimer
2026-05-13 18:42 ` Hannes Laimer [this message]
2026-05-13 18:42 ` [PATCH pve-docs v5 8/8] sdn: add bgp fabric section Hannes Laimer
2026-05-15 10:26 ` superseded: [PATCH docs/manager/network/proxmox{-ve-rs,-perl-rs} v5 0/8] sdn: add BGP fabric Hannes Laimer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260513184213.506775-8-h.laimer@proxmox.com \
--to=h.laimer@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox