From: Stefan Hanreich <s.hanreich@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [PATCH proxmox-ve-rs v2 4/9] ve-config: use constructor instead of instantiating struct
Date: Wed, 13 May 2026 17:13:54 +0200 [thread overview]
Message-ID: <20260513151411.383388-5-s.hanreich@proxmox.com> (raw)
In-Reply-To: <20260513151411.383388-1-s.hanreich@proxmox.com>
This makes it easier to add optional properties to the struct without
having to adjust this call site everytime the internal representation
changes.
Signed-off-by: Stefan Hanreich <s.hanreich@proxmox.com>
---
proxmox-ve-config/src/sdn/fabric/frr.rs | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/proxmox-ve-config/src/sdn/fabric/frr.rs b/proxmox-ve-config/src/sdn/fabric/frr.rs
index ca43cf9..fd99c3c 100644
--- a/proxmox-ve-config/src/sdn/fabric/frr.rs
+++ b/proxmox-ve-config/src/sdn/fabric/frr.rs
@@ -287,7 +287,7 @@ pub fn build_fabric(
/// Helper that builds a OSPF router with a the router_id.
fn build_ospf_router(router_id: Ipv4Addr) -> Result<OspfRouter, anyhow::Error> {
- Ok(ser::ospf::OspfRouter { router_id })
+ Ok(OspfRouter::new(router_id))
}
/// Helper that builds a OpenFabric router from a fabric_id and a [`Net`].
--
2.47.3
next prev parent reply other threads:[~2026-05-13 15:15 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-13 15:13 [PATCH manager/network/proxmox-ve-rs v2 0/9] Implement route redistribution for OSPF Stefan Hanreich
2026-05-13 15:13 ` [PATCH proxmox-ve-rs v2 1/9] frr: ospf: add redistribute setting Stefan Hanreich
2026-05-13 15:13 ` [PATCH proxmox-ve-rs v2 2/9] frr-templates: render " Stefan Hanreich
2026-05-13 15:13 ` [PATCH proxmox-ve-rs v2 3/9] ve-config: add redistribute setting to ospf section config Stefan Hanreich
2026-05-13 15:13 ` Stefan Hanreich [this message]
2026-05-13 15:13 ` [PATCH proxmox-ve-rs v2 5/9] ve-config: ospf: generate redistribute config Stefan Hanreich
2026-05-13 15:13 ` [PATCH pve-network v2 6/9] fabrics: ospf: add redistribute to api types Stefan Hanreich
2026-05-13 15:13 ` [PATCH pve-manager v2 7/9] ui: sdn: fabrics: add redistribution grid component Stefan Hanreich
2026-05-13 15:13 ` [PATCH pve-manager v2 8/9] ui: sdn: fabric edit: allow defining multiple tabs Stefan Hanreich
2026-05-13 15:13 ` [PATCH pve-manager v2 9/9] ui: sdn: ospf fabric: add redistribution grid to ospf fabric Stefan Hanreich
2026-05-15 5:00 ` applied: [PATCH manager/network/proxmox-ve-rs v2 0/9] Implement route redistribution for OSPF Thomas Lamprecht
2026-05-15 5:04 ` Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260513151411.383388-5-s.hanreich@proxmox.com \
--to=s.hanreich@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox