[PATCH ha-manager v3 12/17] manager: remove duplicate service config read in update_crm_commands

[Daniel Kral <d.kral@proxmox.com>]

As there exists a global service config hash in the Manager class now,
remove the redundant read from the handling of the 'arm-ha' CRM command
in PVE::HA::Manager::update_crm_commands().

The HA Manager should work from the same service config in each HA
Manager round to keep consistency.

Signed-off-by: Daniel Kral <d.kral@proxmox.com>
---
changes v2 -> v3:
- new

 src/PVE/HA/Manager.pm | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/src/PVE/HA/Manager.pm b/src/PVE/HA/Manager.pm
index c4088dac..9e8095e1 100644
--- a/src/PVE/HA/Manager.pm
+++ b/src/PVE/HA/Manager.pm
@@ -643,7 +643,7 @@ sub any_resource_motion_queued_or_running {
 sub update_crm_commands {
     my ($self) = @_;
 
-    my ($haenv, $ms, $ns, $ss) = ($self->{haenv}, $self->{ms}, $self->{ns}, $self->{ss});
+    my ($haenv, $ms, $ns, $sc, $ss) = $self->@{qw(haenv ms ns sc ss)};
 
     my $cmdlist = $haenv->read_crm_commands();
 
@@ -733,7 +733,6 @@ sub update_crm_commands {
                 # recheck node info after ignore mode, as services may have been manually
                 # migrated while HA tracking was suspended
                 if ($ms->{disarm}->{mode} eq 'ignore') {
-                    my $sc = $haenv->read_service_config();
                     for my $sid (sort keys %$ss) {
                         my $cd = $sc->{$sid};
                         next if !$cd;
-- 
2.47.3