public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Stefan Hanreich <s.hanreich@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [PATCH proxmox-perl-rs v6 05/24] sdn: prefix lists: validate prefix lists
Date: Fri,  8 May 2026 18:31:14 +0200	[thread overview]
Message-ID: <20260508163134.481912-6-s.hanreich@proxmox.com> (raw)
In-Reply-To: <20260508163134.481912-1-s.hanreich@proxmox.com>

Use the newly supplied validation methods from the prefix list section
config to validate the prefix list configuration when reading or
writing.

Signed-off-by: Stefan Hanreich <s.hanreich@proxmox.com>
---
 pve-rs/src/bindings/sdn/prefix_lists.rs | 18 ++++++++++++++++++
 1 file changed, 18 insertions(+)

diff --git a/pve-rs/src/bindings/sdn/prefix_lists.rs b/pve-rs/src/bindings/sdn/prefix_lists.rs
index 8087a9e..cf900c3 100644
--- a/pve-rs/src/bindings/sdn/prefix_lists.rs
+++ b/pve-rs/src/bindings/sdn/prefix_lists.rs
@@ -17,6 +17,7 @@ pub mod pve_rs_sdn_prefix_lists {
 
     use perlmod::Value;
     use proxmox_section_config::typed::{ApiSectionDataEntry, SectionConfigData};
+    use proxmox_ve_config::common::valid::Validatable;
     use proxmox_ve_config::sdn::prefix_list::api::{
         PrefixList as ApiPrefixList, PrefixListDeletableProperties,
         PrefixListEntry as ApiPrefixListEntry, PrefixListEntryDeletableProperties,
@@ -41,6 +42,10 @@ pub mod pve_rs_sdn_prefix_lists {
         let raw_config = std::str::from_utf8(raw_config)?;
         let config = ConfigPrefixList::parse_section_config("prefix-lists.cfg", raw_config)?;
 
+        for prefix_list in config.values() {
+            prefix_list.validate()?;
+        }
+
         Ok(
             perlmod::instantiate_magic!(&class, MAGIC => Box::new(PerlPrefixListConfig {
                 prefix_lists: Mutex::new(config.deref().clone()),
@@ -57,6 +62,10 @@ pub mod pve_rs_sdn_prefix_lists {
         let prefix_lists: SectionConfigData<ConfigPrefixList> =
             SectionConfigData::from_iter(prefix_lists);
 
+        for prefix_list in prefix_lists.values() {
+            prefix_list.validate()?;
+        }
+
         Ok(
             perlmod::instantiate_magic!(&class, MAGIC => Box::new(PerlPrefixListConfig {
                 prefix_lists: Mutex::new(prefix_lists.deref().clone()),
@@ -70,6 +79,11 @@ pub mod pve_rs_sdn_prefix_lists {
         #[try_from_ref] this: &PerlPrefixListConfig,
     ) -> Result<HashMap<String, ConfigPrefixList>, Error> {
         let config = this.prefix_lists.lock().unwrap();
+
+        for prefix_list in config.values() {
+            prefix_list.validate()?;
+        }
+
         Ok(config.deref().clone())
     }
 
@@ -80,6 +94,10 @@ pub mod pve_rs_sdn_prefix_lists {
     pub fn to_raw(#[try_from_ref] this: &PerlPrefixListConfig) -> Result<String, Error> {
         let config = this.prefix_lists.lock().unwrap();
 
+        for prefix_list in config.values() {
+            prefix_list.validate()?;
+        }
+
         let prefix_lists: SectionConfigData<ConfigPrefixList> =
             SectionConfigData::from_iter(config.deref().clone());
 
-- 
2.47.3





  parent reply	other threads:[~2026-05-08 16:33 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-08 16:31 [PATCH manager/network/proxmox{-ve-rs,-perl-rs} v6 00/24] Add support for route maps / prefix lists to SDN Stefan Hanreich
2026-05-08 16:31 ` [PATCH proxmox-ve-rs v6 01/24] sdn: prefix lists: refactor section config and api format Stefan Hanreich
2026-05-08 16:31 ` [PATCH proxmox-ve-rs v6 02/24] prefix lists: implement validation for prefix lists Stefan Hanreich
2026-05-08 16:31 ` [PATCH proxmox-perl-rs v6 03/24] sdn: prefix lists: refactor existing API endpoint Stefan Hanreich
2026-05-08 16:31 ` [PATCH proxmox-perl-rs v6 04/24] sdn: prefix lists: add crud methods for prefix list entries Stefan Hanreich
2026-05-08 16:31 ` Stefan Hanreich [this message]
2026-05-08 16:31 ` [PATCH proxmox-perl-rs v6 06/24] sdn: route maps: add route map list method Stefan Hanreich
2026-05-08 16:31 ` [PATCH pve-network v6 07/24] api: refactor route map api structure Stefan Hanreich
2026-05-08 16:31 ` [PATCH pve-network v6 08/24] api: refactor prefix list " Stefan Hanreich
2026-05-08 16:31 ` [PATCH pve-manager v6 09/24] ui: sdn: add route map selector Stefan Hanreich
2026-05-08 16:31 ` [PATCH pve-manager v6 10/24] ui: sdn: add prefix list selector Stefan Hanreich
2026-05-08 16:31 ` [PATCH pve-manager v6 11/24] ui: sdn: add panel for managing prefix lists Stefan Hanreich
2026-05-08 16:31 ` [PATCH pve-manager v6 12/24] ui: sdn: add panel for managing route map entries Stefan Hanreich
2026-05-08 16:31 ` [PATCH pve-manager v6 13/24] ui: sdn: bgp controller: allow configuring route maps Stefan Hanreich
2026-05-08 16:31 ` [PATCH pve-manager v6 14/24] ui: sdn: evpn " Stefan Hanreich
2026-05-08 16:31 ` [PATCH pve-manager v6 15/24] ui: sdn: openfabric: add route filter Stefan Hanreich
2026-05-08 16:31 ` [PATCH pve-manager v6 16/24] ui: sdn: ospf: add route filter setting Stefan Hanreich
2026-05-08 16:31 ` [PATCH pve-manager v6 17/24] ui: sdn: prefix list: add missing subjects Stefan Hanreich
2026-05-08 16:31 ` [PATCH pve-manager v6 18/24] sdn: do not fail rendering record data if pending property is missing Stefan Hanreich
2026-05-08 16:31 ` [PATCH pve-manager v6 19/24] ui: sdn: prefix list: adapt to changed api structure Stefan Hanreich
2026-05-08 16:31 ` [PATCH pve-manager v6 20/24] ui: sdn: route maps: adapt to new route map " Stefan Hanreich
2026-05-08 16:31 ` [PATCH pve-manager v6 21/24] ui: sdn: prefix lists: route maps: use integerfields for numbers Stefan Hanreich
2026-05-08 16:31 ` [PATCH pve-manager v6 22/24] ui: sdn: prefix list panel: reload data on deleting prefix list entry Stefan Hanreich
2026-05-08 16:31 ` [PATCH pve-manager v6 23/24] ui: prefix list panel: delete empty le and get properties Stefan Hanreich
2026-05-08 16:31 ` [PATCH pve-manager v6 24/24] ui: prefix list entry panel: make prefix required Stefan Hanreich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260508163134.481912-6-s.hanreich@proxmox.com \
    --to=s.hanreich@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal