public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Gabriel Goller <g.goller@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [PATCH network] sdn: include fabrics when checking for pending changes
Date: Thu,  7 May 2026 15:09:56 +0200	[thread overview]
Message-ID: <20260507131000.304156-1-g.goller@proxmox.com> (raw)

The lock api endpoint uses `has_pending_changes` to determine whether
the SDN configuration can be locked. Previously, the fabric config was
not included in the check, allowing a config with pending fabric changes
to be locked.

Reported-by: Stefan Hanreich <s.hanreich@proxmox.com>
Signed-off-by: Gabriel Goller <g.goller@proxmox.com>
---
 src/PVE/Network/SDN.pm | 1 +
 1 file changed, 1 insertion(+)

diff --git a/src/PVE/Network/SDN.pm b/src/PVE/Network/SDN.pm
index fcb0f97c339b..33a3cf352496 100644
--- a/src/PVE/Network/SDN.pm
+++ b/src/PVE/Network/SDN.pm
@@ -252,6 +252,7 @@ sub has_pending_changes {
         vnets => PVE::Network::SDN::Vnets::config(),
         subnets => PVE::Network::SDN::Subnets::config(),
         controllers => PVE::Network::SDN::Controllers::config(),
+        fabrics => { ids => PVE::Network::SDN::Fabrics::config()->to_sections() },
         'route-maps' => { ids => PVE::Network::SDN::RouteMaps::config()->to_sections() },
         'prefix-lists' => { ids => PVE::Network::SDN::PrefixLists::config()->to_sections() },
     };
-- 
2.47.3





                 reply	other threads:[~2026-05-07 13:10 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260507131000.304156-1-g.goller@proxmox.com \
    --to=g.goller@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal