From: David Riley <d.riley@proxmox.com>
To: pve-devel@lists.proxmox.com
Cc: David Riley <d.riley@proxmox.com>
Subject: [PATCH pve-manager v3] api: sdn: fix trailing slashes in delete requests
Date: Tue, 28 Apr 2026 14:21:56 +0200 [thread overview]
Message-ID: <20260428122156.82218-1-d.riley@proxmox.com> (raw)
Fixes delete request containing double slashes (//), resulting in a
URI like `/sdn/dns//<dns>`. Although this gets normalized on the
server, a strict firewall/proxy might cause problems.
According to RFC 2396, a path may only consist of a
single slash [0].
[0] https://www.rfc-editor.org/rfc/rfc2396#section-3.3
Suggested-by: Nicolas Frey <n.frey@proxmox.com>
Signed-off-by: David Riley <d.riley@proxmox.com>
---
Notes:
v3:
* Fix commit message to reflect the change as "removing trailing
slash" rather than "fixing double slash".
* Add technical context regarding RFC 2396
* Add Suggested-by tag for Nicolas Frey.
v2:
* Fix trailing slashes in ControllerView and IpamView to address the
same behavior across the SDN views
www/manager6/sdn/ControllerView.js | 2 +-
www/manager6/sdn/DnsView.js | 2 +-
www/manager6/sdn/IpamView.js | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/www/manager6/sdn/ControllerView.js b/www/manager6/sdn/ControllerView.js
index d85e85e4..cd8b4bc0 100644
--- a/www/manager6/sdn/ControllerView.js
+++ b/www/manager6/sdn/ControllerView.js
@@ -60,7 +60,7 @@ Ext.define('PVE.sdn.ControllerView', {
let remove_btn = Ext.create('Proxmox.button.StdRemoveButton', {
selModel: sm,
- baseurl: '/cluster/sdn/controllers/',
+ baseurl: '/cluster/sdn/controllers',
callback: () => store.load(),
});
diff --git a/www/manager6/sdn/DnsView.js b/www/manager6/sdn/DnsView.js
index ba5ada5a..c5cd32bb 100644
--- a/www/manager6/sdn/DnsView.js
+++ b/www/manager6/sdn/DnsView.js
@@ -59,7 +59,7 @@ Ext.define('PVE.sdn.DnsView', {
let remove_btn = Ext.create('Proxmox.button.StdRemoveButton', {
selModel: sm,
- baseurl: '/cluster/sdn/dns/',
+ baseurl: '/cluster/sdn/dns',
callback: () => store.load(),
});
diff --git a/www/manager6/sdn/IpamView.js b/www/manager6/sdn/IpamView.js
index ca9068cf..1764c184 100644
--- a/www/manager6/sdn/IpamView.js
+++ b/www/manager6/sdn/IpamView.js
@@ -58,7 +58,7 @@ Ext.define('PVE.sdn.IpamView', {
let remove_btn = Ext.create('Proxmox.button.StdRemoveButton', {
selModel: sm,
- baseurl: '/cluster/sdn/ipams/',
+ baseurl: '/cluster/sdn/ipams',
callback: () => store.load(),
});
--
2.47.3
reply other threads:[~2026-04-28 12:22 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260428122156.82218-1-d.riley@proxmox.com \
--to=d.riley@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox