[PATCH manager 5/5] ceph: drop duplicate release-to-codename map in upgrade checks

[Kefu Chai <k.chai@proxmox.com>]

Drop the local $ceph_release2code map in PVE::Ceph::UpgradeCheck and
look up codenames through PVE::Ceph::Releases::get_codename_for_major_release()
instead. The map duplicated data already maintained in Releases.pm, so
adding a new Ceph release would have required two updates.

No functional change.

Signed-off-by: Kefu Chai <k.chai@proxmox.com>
---
 PVE/Ceph/UpgradeCheck.pm | 27 +++++++++++----------------
 1 file changed, 11 insertions(+), 16 deletions(-)

diff --git a/PVE/Ceph/UpgradeCheck.pm b/PVE/Ceph/UpgradeCheck.pm
index 09418df3..4103c136 100644
--- a/PVE/Ceph/UpgradeCheck.pm
+++ b/PVE/Ceph/UpgradeCheck.pm
@@ -17,20 +17,10 @@ use PVE::Ceph::Releases;
 use PVE::Ceph::Tools;
 use PVE::Cluster;
 
-my $ceph_release2code = {
-    '12' => 'Luminous',
-    '13' => 'Mimic',
-    '14' => 'Nautilus',
-    '15' => 'Octopus',
-    '16' => 'Pacific',
-    '17' => 'Quincy',
-    '18' => 'Reef',
-    '19' => 'Squid',
-    '20' => 'Tentacle',
-};
 my $default_supported_release = 19; # available before and after the current major upgrade
-my $default_supported_code_name = $ceph_release2code->{"$default_supported_release"}
-    or die "inconsistent source code, could not map expected ceph version to code name!";
+my $default_supported_code_name =
+    ucfirst(PVE::Ceph::Releases::get_codename_for_major_release($default_supported_release)
+        // die "inconsistent source code, could not map expected ceph version to code name!\n");
 
 sub run_checks {
     my (%args) = @_;
@@ -118,13 +108,18 @@ sub check_versions {
     my @out;
     my $noout_wanted = 1;
 
-    my $supported_code_name = $supported_release == $default_supported_release
+    my $supported_code_name =
+        $supported_release == $default_supported_release
         ? $default_supported_code_name
-        : ($ceph_release2code->{"$supported_release"} // 'unknown');
+        : do {
+            my $codename = PVE::Ceph::Releases::get_codename_for_major_release($supported_release);
+            defined($codename) ? ucfirst($codename) : 'unknown';
+        };
 
     push @out, { level => 'info', msg => "checking local Ceph version.." };
     if (my $release = eval { PVE::Ceph::Tools::get_local_version(1) }) {
-        my $code_name = $ceph_release2code->{"$release"} || 'unknown';
+        my $codename = PVE::Ceph::Releases::get_codename_for_major_release($release);
+        my $code_name = defined($codename) ? ucfirst($codename) : 'unknown';
         if ($release == $supported_release) {
             push @out,
                 {
-- 
2.47.3