public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Fiona Ebner <f.ebner@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [PATCH qemu-server] fix #3662: tpm: use QSD to give swtpm access to iscsi-based volumes
Date: Mon, 27 Apr 2026 18:01:08 +0200	[thread overview]
Message-ID: <20260427160205.56965-1-f.ebner@proxmox.com> (raw)

The iSCSIDirect and ZFS-over-iSCSI plugins do not implement
map_volume() and only provide an iscsi protocol path. Use QSD to make
such volumes accessible to swtpm.

Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
---
 src/PVE/QemuServer/Drive.pm | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/src/PVE/QemuServer/Drive.pm b/src/PVE/QemuServer/Drive.pm
index 625ed80c..b80b7dbb 100644
--- a/src/PVE/QemuServer/Drive.pm
+++ b/src/PVE/QemuServer/Drive.pm
@@ -1159,8 +1159,15 @@ sub drive_uses_qsd_fuse {
 
     if ($drive->{interface} eq 'tpmstate') {
         my ($storeid) = PVE::Storage::parse_volume_id($drive->{file}, 1);
+        return if !$storeid; # not managed by the PVE storage layer
+
+        # The iSCSIDirect and ZFS-over-iSCSI plugins do not implement map_volume() and only provide
+        # an iscsi protocol path. Use QSD to make such volumes accessible to swtpm.
+        my $path = PVE::Storage::path($storecfg, $drive->{file});
+        return 1 if $path =~ m!^iscsi://!;
+
         my $format = checked_volume_format($storecfg, $drive->{file});
-        return $storeid && $format ne 'raw';
+        return $format ne 'raw';
     }
 
     return;
-- 
2.47.3





                 reply	other threads:[~2026-04-27 16:03 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260427160205.56965-1-f.ebner@proxmox.com \
    --to=f.ebner@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal