public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
* [PATCH manager] api: cluster: ceph: fix osd metadata return schema
@ 2026-04-09 11:47 Kefu Chai
  2026-04-12 11:53 ` superseded: [PATCH manager/storage 0/2] fix #7000: rbd: graceful handling of corrupt/inaccessible images Kefu Chai
  0 siblings, 1 reply; 2+ messages in thread
From: Kefu Chai @ 2026-04-09 11:47 UTC (permalink / raw)
  To: pve-devel

The 'osd' field used 'properties' inside a 'type: array', which is
invalid -- arrays use 'items' to describe their elements. The 'osd
metadata' command returns a bare JSON array where each element is an
object describing one OSD, so replace 'properties' with 'items'.

The runtime behavior is unaffected; this is a schema-only correction.

Fixes: https://bugzilla.proxmox.com/show_bug.cgi?id=5346
Signed-off-by: Kefu Chai <k.chai@proxmox.com>
---
 PVE/API2/Cluster/Ceph.pm | 62 +++++++++++++++++++---------------------
 1 file changed, 30 insertions(+), 32 deletions(-)

diff --git a/PVE/API2/Cluster/Ceph.pm b/PVE/API2/Cluster/Ceph.pm
index 399460fb..1e9b4482 100644
--- a/PVE/API2/Cluster/Ceph.pm
+++ b/PVE/API2/Cluster/Ceph.pm
@@ -193,39 +193,37 @@ __PACKAGE__->register_method({
             osd => {
                 type => "array",
                 description => "OSDs configured in the cluster and their properties.",
-                properties => {
-                    "{id}" => {
-                        type => "object",
-                        description => "Useful properties are listed, but not the full list.",
-                        properties => {
-                            id => {
-                                type => "integer",
-                                description => "OSD ID.",
-                            },
-                            front_addr => {
-                                type => "string",
-                                description =>
-                                    "Bind addresses and ports for frontend traffic to OSDs.",
-                            },
-                            back_addr => {
-                                type => "string",
-                                description =>
-                                    "Bind addresses and ports for backend inter OSD traffic.",
-                            },
-                            device_id => {
-                                type => "string",
-                                description => "Devices used by the OSD.",
-                            },
-                            osd_data => {
-                                type => "string",
-                                description => "Path to the OSD data directory.",
-                            },
-                            osd_objectstore => {
-                                type => "string",
-                                description => "OSD objectstore type.",
-                            },
-                            %{$metadata_common_props},
+                items => {
+                    type => "object",
+                    description => "Useful properties are listed, but not the full list.",
+                    properties => {
+                        id => {
+                            type => "integer",
+                            description => "OSD ID.",
+                        },
+                        front_addr => {
+                            type => "string",
+                            description =>
+                                "Bind addresses and ports for frontend traffic to OSDs.",
+                        },
+                        back_addr => {
+                            type => "string",
+                            description =>
+                                "Bind addresses and ports for backend inter OSD traffic.",
+                        },
+                        device_id => {
+                            type => "string",
+                            description => "Devices used by the OSD.",
+                        },
+                        osd_data => {
+                            type => "string",
+                            description => "Path to the OSD data directory.",
+                        },
+                        osd_objectstore => {
+                            type => "string",
+                            description => "OSD objectstore type.",
                         },
+                        %{$metadata_common_props},
                     },
                 },
             },
-- 
2.47.3





^ permalink raw reply	[flat|nested] 2+ messages in thread

* superseded: [PATCH manager/storage 0/2] fix #7000: rbd: graceful handling of corrupt/inaccessible images
  2026-04-09 11:47 [PATCH manager] api: cluster: ceph: fix osd metadata return schema Kefu Chai
@ 2026-04-12 11:53 ` Kefu Chai
  0 siblings, 0 replies; 2+ messages in thread
From: Kefu Chai @ 2026-04-12 11:53 UTC (permalink / raw)
  To: pve-devel

superseded by https://lore.proxmox.com/pve-devel/20260412115206.4171975-1-k.chai@proxmox.com/




^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2026-04-12 11:53 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-04-09 11:47 [PATCH manager] api: cluster: ceph: fix osd metadata return schema Kefu Chai
2026-04-12 11:53 ` superseded: [PATCH manager/storage 0/2] fix #7000: rbd: graceful handling of corrupt/inaccessible images Kefu Chai

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal