public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Kefu Chai <k.chai@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [PATCH ceph] patches: drop patch disabling elastic_shared_blobs workaround
Date: Wed,  8 Apr 2026 14:41:12 +0800	[thread overview]
Message-ID: <20260408064112.1871364-1-k.chai@proxmox.com> (raw)

The underlying crash (tracker#70390) was fixed upstream by PR #65964
(commit 04d1d8ad575), which is included in Tentacle 20.2.1. The
workaround of disabling bluestore_elastic_shared_blobs by default is
no longer needed.

[0] https://tracker.ceph.com/issues/70390
[1] https://github.com/ceph/ceph/pull/65964/

Signed-off-by: Kefu Chai <k.chai@proxmox.com>
---
 ...10-d-rules-disable-jaeger-telemetry.patch} |  0
 ...shared_blob-to-prevent-crashing-OSDs.patch | 33 -------------------
 ...thon3-distutils-not-available-in-De.patch} |  0
 ...p-legacy-init.d-ceph-script-anymore.patch} |  0
 ...port-by-making-NOTIFY_TYPES-in-py-m.patch} |  0
 ...e-on_progress-callbacks-to-prevent-.patch} |  0
 patches/series                                | 11 +++----
 7 files changed, 5 insertions(+), 39 deletions(-)
 rename patches/{0011-d-rules-disable-jaeger-telemetry.patch => 0010-d-rules-disable-jaeger-telemetry.patch} (100%)
 delete mode 100644 patches/0010-disable-elastic_shared_blob-to-prevent-crashing-OSDs.patch
 rename patches/{0012-d-py3dist-drop-python3-distutils-not-available-in-De.patch => 0011-d-py3dist-drop-python3-distutils-not-available-in-De.patch} (100%)
 rename patches/{0013-debian-do-not-ship-legacy-init.d-ceph-script-anymore.patch => 0012-debian-do-not-ship-legacy-init.d-ceph-script-anymore.patch} (100%)
 rename patches/{0014-mgr-fix-module-import-by-making-NOTIFY_TYPES-in-py-m.patch => 0013-mgr-fix-module-import-by-making-NOTIFY_TYPES-in-py-m.patch} (100%)
 rename patches/{0015-pybind-rbd-disable-on_progress-callbacks-to-prevent-.patch => 0014-pybind-rbd-disable-on_progress-callbacks-to-prevent-.patch} (100%)

diff --git a/patches/0011-d-rules-disable-jaeger-telemetry.patch b/patches/0010-d-rules-disable-jaeger-telemetry.patch
similarity index 100%
rename from patches/0011-d-rules-disable-jaeger-telemetry.patch
rename to patches/0010-d-rules-disable-jaeger-telemetry.patch
diff --git a/patches/0010-disable-elastic_shared_blob-to-prevent-crashing-OSDs.patch b/patches/0010-disable-elastic_shared_blob-to-prevent-crashing-OSDs.patch
deleted file mode 100644
index d8fc5e86787..00000000000
--- a/patches/0010-disable-elastic_shared_blob-to-prevent-crashing-OSDs.patch
+++ /dev/null
@@ -1,33 +0,0 @@
-From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
-From: Stoiko Ivanov <s.ivanov@proxmox.com>
-Date: Tue, 8 Apr 2025 12:13:10 +0200
-Subject: [PATCH] disable elastic_shared_blob to prevent crashing OSDs
-
-reported in our community forum and upstream:
-https://forum.proxmox.com/threads/164735/
-https://tracker.ceph.com/issues/70390
-https://github.com/ceph/ceph/pull/62724
-
-fix seems trivial, and the feature is quite new:
-https://ceph.io/assets/pdfs/events/2024/ceph-days-nyc/Diving%20Deep%20with%20Squid.pdf
-
-Signed-off-by: Stoiko Ivanov <s.ivanov@proxmox.com>
-Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
-Signed-off-by: Max R. Carrara <m.carrara@proxmox.com>
----
- src/common/options/global.yaml.in | 2 +-
- 1 file changed, 1 insertion(+), 1 deletion(-)
-
-diff --git a/src/common/options/global.yaml.in b/src/common/options/global.yaml.in
-index 99cadcdf35e..f2148e936f8 100644
---- a/src/common/options/global.yaml.in
-+++ b/src/common/options/global.yaml.in
-@@ -5140,7 +5140,7 @@ options:
-   long_desc: Overwrites on snapped objects cause shared blob count to grow.
-     It has a very negative performance effect. When enabled shared blob count
-     is significantly reduced.
--  default: true
-+  default: false
-   flags:
-   - create
-   with_legacy: false
diff --git a/patches/0012-d-py3dist-drop-python3-distutils-not-available-in-De.patch b/patches/0011-d-py3dist-drop-python3-distutils-not-available-in-De.patch
similarity index 100%
rename from patches/0012-d-py3dist-drop-python3-distutils-not-available-in-De.patch
rename to patches/0011-d-py3dist-drop-python3-distutils-not-available-in-De.patch
diff --git a/patches/0013-debian-do-not-ship-legacy-init.d-ceph-script-anymore.patch b/patches/0012-debian-do-not-ship-legacy-init.d-ceph-script-anymore.patch
similarity index 100%
rename from patches/0013-debian-do-not-ship-legacy-init.d-ceph-script-anymore.patch
rename to patches/0012-debian-do-not-ship-legacy-init.d-ceph-script-anymore.patch
diff --git a/patches/0014-mgr-fix-module-import-by-making-NOTIFY_TYPES-in-py-m.patch b/patches/0013-mgr-fix-module-import-by-making-NOTIFY_TYPES-in-py-m.patch
similarity index 100%
rename from patches/0014-mgr-fix-module-import-by-making-NOTIFY_TYPES-in-py-m.patch
rename to patches/0013-mgr-fix-module-import-by-making-NOTIFY_TYPES-in-py-m.patch
diff --git a/patches/0015-pybind-rbd-disable-on_progress-callbacks-to-prevent-.patch b/patches/0014-pybind-rbd-disable-on_progress-callbacks-to-prevent-.patch
similarity index 100%
rename from patches/0015-pybind-rbd-disable-on_progress-callbacks-to-prevent-.patch
rename to patches/0014-pybind-rbd-disable-on_progress-callbacks-to-prevent-.patch
diff --git a/patches/series b/patches/series
index 7734bdd102e..eaf6dd3cbb1 100644
--- a/patches/series
+++ b/patches/series
@@ -7,9 +7,8 @@
 0007-fix-compatibility-with-CPUs-not-supporting-SSE-4.1-i.patch
 0008-ceph-osd-postinst-do-not-always-reload-all-sysctl-se.patch
 0009-ceph-crash-change-order-of-client-names.patch
-0010-disable-elastic_shared_blob-to-prevent-crashing-OSDs.patch
-0011-d-rules-disable-jaeger-telemetry.patch
-0012-d-py3dist-drop-python3-distutils-not-available-in-De.patch
-0013-debian-do-not-ship-legacy-init.d-ceph-script-anymore.patch
-0014-mgr-fix-module-import-by-making-NOTIFY_TYPES-in-py-m.patch
-0015-pybind-rbd-disable-on_progress-callbacks-to-prevent-.patch
+0010-d-rules-disable-jaeger-telemetry.patch
+0011-d-py3dist-drop-python3-distutils-not-available-in-De.patch
+0012-debian-do-not-ship-legacy-init.d-ceph-script-anymore.patch
+0013-mgr-fix-module-import-by-making-NOTIFY_TYPES-in-py-m.patch
+0014-pybind-rbd-disable-on_progress-callbacks-to-prevent-.patch
-- 
2.47.3





                 reply	other threads:[~2026-04-08  6:41 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260408064112.1871364-1-k.chai@proxmox.com \
    --to=k.chai@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal