public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Daniel Kral <d.kral@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [PATCH manager v4 27/28] ui: move cluster resource scheduling from dc/options into separate component
Date: Thu,  2 Apr 2026 14:44:21 +0200	[thread overview]
Message-ID: <20260402124817.416232-28-d.kral@proxmox.com> (raw)
In-Reply-To: <20260402124817.416232-1-d.kral@proxmox.com>

This is in preparation to the next patch, which adds a view model to the
component to make options dependent on each other's state.

Signed-off-by: Daniel Kral <d.kral@proxmox.com>
---
changes v3 -> v4:
- new!

 www/manager6/Makefile           |  1 +
 www/manager6/dc/OptionView.js   | 38 +++++-----------------
 www/manager6/form/CRSOptions.js | 56 +++++++++++++++++++++++++++++++++
 3 files changed, 64 insertions(+), 31 deletions(-)
 create mode 100644 www/manager6/form/CRSOptions.js

diff --git a/www/manager6/Makefile b/www/manager6/Makefile
index 4558d53e..b0c94b32 100644
--- a/www/manager6/Makefile
+++ b/www/manager6/Makefile
@@ -27,6 +27,7 @@ JSSRC= 							\
 	form/BridgeSelector.js				\
 	form/BusTypeSelector.js				\
 	form/CPUModelSelector.js			\
+	form/CRSOptions.js				\
 	form/CacheTypeSelector.js			\
 	form/CalendarEvent.js				\
 	form/CephPoolSelector.js			\
diff --git a/www/manager6/dc/OptionView.js b/www/manager6/dc/OptionView.js
index fa87832b..7c8d3792 100644
--- a/www/manager6/dc/OptionView.js
+++ b/www/manager6/dc/OptionView.js
@@ -180,38 +180,14 @@ Ext.define('PVE.dc.OptionView', {
                 },
             ],
         });
-        me.add_inputpanel_row('crs', gettext('Cluster Resource Scheduling'), {
+        me.rows.crs = {
+            required: true,
             renderer: PVE.Utils.render_as_property_string,
-            width: 450,
-            labelWidth: 120,
-            url: '/api2/extjs/cluster/options',
-            onlineHelp: 'ha_manager_crs',
-            items: [
-                {
-                    xtype: 'proxmoxKVComboBox',
-                    name: 'ha',
-                    fieldLabel: gettext('HA Scheduling'),
-                    deleteEmpty: false,
-                    value: '__default__',
-                    comboItems: [
-                        ['__default__', Proxmox.Utils.defaultText + ' (basic)'],
-                        ['basic', gettext('Basic (Resource Count)')],
-                        ['static', gettext('Static Load')],
-                        ['dynamic', gettext('Dynamic Load')],
-                    ],
-                    defaultValue: '__default__',
-                },
-                {
-                    xtype: 'proxmoxcheckbox',
-                    name: 'ha-rebalance-on-start',
-                    fieldLabel: gettext('Rebalance on Start'),
-                    boxLabel: gettext(
-                        'Use CRS to select the least loaded node when starting an HA service',
-                    ),
-                    value: 0,
-                },
-            ],
-        });
+            header: gettext('Cluster Resource Scheduling'),
+            editor: {
+                xtype: 'pveCRSOptions',
+            },
+        };
         me.add_inputpanel_row('u2f', gettext('U2F Settings'), {
             renderer: (v) =>
                 !v ? Proxmox.Utils.NoneText : Ext.htmlEncode(PVE.Parser.printPropertyString(v)),
diff --git a/www/manager6/form/CRSOptions.js b/www/manager6/form/CRSOptions.js
new file mode 100644
index 00000000..b22c5c99
--- /dev/null
+++ b/www/manager6/form/CRSOptions.js
@@ -0,0 +1,56 @@
+Ext.define('PVE.form.CRSOptions', {
+    extend: 'Proxmox.window.Edit',
+    alias: 'widget.pveCRSOptions',
+
+    width: 450,
+    url: '/api2/extjs/cluster/options',
+    onlineHelp: 'ha_manager_crs',
+
+    fieldDefaults: {
+        labelWidth: 120,
+    },
+
+    setValues: function (values) {
+        Ext.Array.each(this.query('inputpanel'), (panel) => {
+            panel.setValues(values.crs);
+        });
+    },
+
+    items: [
+        {
+            xtype: 'inputpanel',
+            onGetValues: function (values) {
+                if (values === undefined || Object.keys(values).length === 0) {
+                    return { delete: 'crs' };
+                } else {
+                    return { crs: PVE.Parser.printPropertyString(values) };
+                }
+            },
+            items: [
+                {
+                    xtype: 'proxmoxKVComboBox',
+                    name: 'ha',
+                    fieldLabel: gettext('HA Scheduling'),
+                    deleteEmpty: false,
+                    value: '__default__',
+                    comboItems: [
+                        ['__default__', Proxmox.Utils.defaultText + ' (basic)'],
+                        ['basic', gettext('Basic (Resource Count)')],
+                        ['static', gettext('Static Load')],
+                        ['dynamic', gettext('Dynamic Load')],
+                    ],
+                    defaultValue: '__default__',
+                },
+                {
+                    xtype: 'proxmoxcheckbox',
+                    name: 'ha-rebalance-on-start',
+                    fieldLabel: gettext('Rebalance on Start'),
+                    boxLabel: gettext(
+                        'Use CRS to select the least loaded node when starting an HA service',
+                    ),
+                    value: 0,
+                },
+            ],
+        },
+    ],
+});
-- 
2.47.3





  parent reply	other threads:[~2026-04-02 12:50 UTC|newest]

Thread overview: 41+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-02 12:43 [PATCH cluster/ha-manager/manager v4 00/28] dynamic scheduler + load rebalancer Daniel Kral
2026-04-02 12:43 ` [PATCH cluster v4 01/28] datacenter config: restructure verbose description for the ha crs option Daniel Kral
2026-04-02 12:43 ` [PATCH cluster v4 02/28] datacenter config: add dynamic load scheduler option Daniel Kral
2026-04-02 12:43 ` [PATCH cluster v4 03/28] datacenter config: add auto rebalancing options Daniel Kral
2026-04-02 13:07   ` Dominik Rusovac
2026-04-02 12:43 ` [PATCH ha-manager v4 04/28] env: pve2: implement dynamic node and service stats Daniel Kral
2026-04-02 13:40   ` Dominik Rusovac
2026-04-02 12:43 ` [PATCH ha-manager v4 05/28] sim: hardware: pass correct types for static stats Daniel Kral
2026-04-02 12:44 ` [PATCH ha-manager v4 06/28] sim: hardware: factor out static stats' default values Daniel Kral
2026-04-02 12:44 ` [PATCH ha-manager v4 07/28] sim: hardware: fix static stats guard Daniel Kral
2026-04-02 12:44 ` [PATCH ha-manager v4 08/28] sim: hardware: handle dynamic service stats Daniel Kral
2026-04-02 12:44 ` [PATCH ha-manager v4 09/28] sim: hardware: add set-dynamic-stats command Daniel Kral
2026-04-02 12:44 ` [PATCH ha-manager v4 10/28] sim: hardware: add getters for dynamic {node,service} stats Daniel Kral
2026-04-02 12:44 ` [PATCH ha-manager v4 11/28] usage: pass service data to add_service_usage Daniel Kral
2026-04-02 12:44 ` [PATCH ha-manager v4 12/28] usage: pass service data to get_used_service_nodes Daniel Kral
2026-04-02 12:44 ` [PATCH ha-manager v4 13/28] add running flag to non-HA cluster service stats Daniel Kral
2026-04-02 12:44 ` [PATCH ha-manager v4 14/28] usage: use add_service to add service usage to nodes Daniel Kral
2026-04-02 12:44 ` [PATCH ha-manager v4 15/28] usage: add dynamic usage scheduler Daniel Kral
2026-04-02 12:44 ` [PATCH ha-manager v4 16/28] test: add dynamic usage scheduler test cases Daniel Kral
2026-04-02 12:44 ` [PATCH ha-manager v4 17/28] manager: rename execute_migration to queue_resource_motion Daniel Kral
2026-04-02 12:44 ` [PATCH ha-manager v4 18/28] manager: update_crs_scheduler_mode: factor out crs config Daniel Kral
2026-04-02 12:44 ` [PATCH ha-manager v4 19/28] implement automatic rebalancing Daniel Kral
2026-04-02 13:14   ` Dominik Rusovac
2026-04-02 12:44 ` [PATCH ha-manager v4 20/28] test: add resource bundle generation test cases Daniel Kral
2026-04-02 12:44 ` [PATCH ha-manager v4 21/28] test: add dynamic automatic rebalancing system " Daniel Kral
2026-04-02 13:21   ` Dominik Rusovac
2026-04-02 12:44 ` [PATCH ha-manager v4 22/28] test: add static " Daniel Kral
2026-04-02 13:23   ` Dominik Rusovac
2026-04-02 12:44 ` [PATCH ha-manager v4 23/28] test: add automatic rebalancing system test cases with TOPSIS method Daniel Kral
2026-04-02 13:29   ` Dominik Rusovac
2026-04-02 12:44 ` [PATCH ha-manager v4 24/28] test: add automatic rebalancing system test cases with affinity rules Daniel Kral
2026-04-02 12:44 ` [PATCH manager v4 25/28] ui: dc/options: make the ha crs strings translatable Daniel Kral
2026-04-02 13:33   ` Dominik Rusovac
2026-04-02 12:44 ` [PATCH manager v4 26/28] ui: dc/options: add dynamic load scheduler option for ha crs Daniel Kral
2026-04-02 13:33   ` Dominik Rusovac
2026-04-02 12:44 ` Daniel Kral [this message]
2026-04-02 13:35   ` [PATCH manager v4 27/28] ui: move cluster resource scheduling from dc/options into separate component Dominik Rusovac
2026-04-02 12:44 ` [PATCH manager v4 28/28] ui: form: add crs auto rebalancing options Daniel Kral
2026-04-02 13:38   ` Dominik Rusovac
2026-04-02 14:24 ` [PATCH cluster/ha-manager/manager v4 00/28] dynamic scheduler + load rebalancer Dominik Rusovac
2026-04-02 16:07 ` applied: " Thomas Lamprecht

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260402124817.416232-28-d.kral@proxmox.com \
    --to=d.kral@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal