public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Stefan Hanreich <s.hanreich@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [PATCH proxmox-ve-rs v2 14/34] ve-config: frr: implement frr config generation for route maps
Date: Wed,  1 Apr 2026 16:39:23 +0200	[thread overview]
Message-ID: <20260401143957.386809-15-s.hanreich@proxmox.com> (raw)
In-Reply-To: <20260401143957.386809-1-s.hanreich@proxmox.com>

Implements conversion traits for all the section config types, so they
can be converted into their respective FRR template counterpart.

This module contains a helper for adding all route map entries to an
existing FRR configuration. If the pre-existing FRR configuration
contains a route map that has the same name as at least one entry in
the configuration, then the *whole* route map will get overwritten by
the route map defined in the section config.

The helper also automatically re-orders route map entries according to
their ordering number. This allows for deterministic FRR configuration
output, which is required for stable tests and convenient for human
readability.

Signed-off-by: Stefan Hanreich <s.hanreich@proxmox.com>
---
 proxmox-ve-config/src/sdn/route_map.rs | 147 +++++++++++++++++++++++++
 1 file changed, 147 insertions(+)

diff --git a/proxmox-ve-config/src/sdn/route_map.rs b/proxmox-ve-config/src/sdn/route_map.rs
index 61607d7..8f9c17c 100644
--- a/proxmox-ve-config/src/sdn/route_map.rs
+++ b/proxmox-ve-config/src/sdn/route_map.rs
@@ -441,6 +441,153 @@ impl ApiType for MatchAction {
     .schema();
 }
 
+#[cfg(feature = "frr")]
+pub mod frr {
+    //! Route Map Entry FRR types
+    //!
+    //! This module contains implementations of conversion traits for the section config types, so
+    //! they can be converted to the respective proxmox-frr types. This enables easy conversion to
+    //! the proxmox-frr types and makes it possible to generate the FRR configuration for the Route
+    //! Map entries.
+
+    use super::*;
+
+    use std::collections::HashMap;
+
+    use proxmox_frr::ser::{
+        route_map::{
+            RouteMapEntry as FrrRouteMapEntry, RouteMapExitAction as FrrRouteMapExitAction,
+            RouteMapMatch as FrrRouteMapMatch, RouteMapName as FrrRouteMapName,
+            RouteMapSet as FrrRouteMapSet,
+        },
+        FrrConfig,
+    };
+
+    use crate::sdn::route_map::RouteMapAction;
+
+    impl From<MatchAction> for FrrRouteMapMatch {
+        fn from(value: MatchAction) -> Self {
+            match value {
+                MatchAction::RouteType(evpn_route_type) => Self::RouteType(evpn_route_type),
+                MatchAction::Vni(vni) => Self::Vni(vni),
+                MatchAction::IpAddressPrefixList(prefix_list_name) => {
+                    Self::IpAddressPrefixList(prefix_list_name.into())
+                }
+                MatchAction::Ip6AddressPrefixList(prefix_list_name) => {
+                    Self::Ip6AddressPrefixList(prefix_list_name.into())
+                }
+                MatchAction::IpNextHopPrefixList(prefix_list_name) => {
+                    Self::IpNextHopPrefixList(prefix_list_name.into())
+                }
+                MatchAction::Ip6NextHopPrefixList(prefix_list_name) => {
+                    Self::Ip6NextHopPrefixList(prefix_list_name.into())
+                }
+                MatchAction::IpNextHopAddress(ipv4_addr) => Self::IpNextHopAddress(*ipv4_addr),
+                MatchAction::Ip6NextHopAddress(ipv6_addr) => Self::Ip6NextHopAddress(*ipv6_addr),
+                MatchAction::Metric(metric) => Self::Metric(metric),
+                MatchAction::LocalPreference(local_preference) => {
+                    Self::LocalPreference(local_preference)
+                }
+                MatchAction::Peer(ip_addr) => Self::Peer(ip_addr),
+                MatchAction::Tag(tag) => Self::Tag(tag),
+            }
+        }
+    }
+
+    impl From<SetAction> for FrrRouteMapSet {
+        fn from(value: SetAction) -> Self {
+            match value {
+                SetAction::IpNextHopPeerAddress => Self::IpNextHopPeerAddress,
+                SetAction::IpNextHopUnchanged => Self::IpNextHopUnchanged,
+                SetAction::IpNextHop(ipv4_addr) => Self::IpNextHop(*ipv4_addr),
+                SetAction::Ip6NextHopPeerAddress => Self::Ip6NextHopPeerAddress,
+                SetAction::Ip6NextHopPreferGlobal => Self::Ip6NextHopPreferGlobal,
+                SetAction::Ip6NextHop(ipv6_addr) => Self::Ip6NextHop(*ipv6_addr),
+                SetAction::LocalPreference(local_preference) => {
+                    Self::LocalPreference(local_preference)
+                }
+                SetAction::Tag(tag) => Self::Tag(tag),
+                SetAction::Weight(weight) => Self::Weight(weight),
+                SetAction::Metric(metric) => Self::Metric(metric),
+                SetAction::Src(src) => Self::Src(src),
+            }
+        }
+    }
+
+    impl From<ExitAction> for FrrRouteMapExitAction {
+        fn from(value: ExitAction) -> Self {
+            match value {
+                ExitAction::OnMatchNext => FrrRouteMapExitAction::OnMatchNext,
+                ExitAction::OnMatchGoto(n) => FrrRouteMapExitAction::OnMatchGoto(n),
+                ExitAction::Continue(n) => FrrRouteMapExitAction::Continue(n),
+            }
+        }
+    }
+
+    impl From<RouteMapId> for FrrRouteMapName {
+        fn from(value: RouteMapId) -> Self {
+            FrrRouteMapName::new(value.0)
+        }
+    }
+
+    impl From<RouteMapEntry> for FrrRouteMapEntry {
+        fn from(value: RouteMapEntry) -> FrrRouteMapEntry {
+            FrrRouteMapEntry {
+                seq: value.id.order,
+                action: match value.action {
+                    RouteMapAction::Permit => proxmox_frr::ser::route_map::AccessAction::Permit,
+                    RouteMapAction::Deny => proxmox_frr::ser::route_map::AccessAction::Deny,
+                },
+                matches: value
+                    .match_actions
+                    .into_iter()
+                    .map(|match_action| match_action.into_inner().into())
+                    .collect(),
+                sets: value
+                    .set_actions
+                    .into_iter()
+                    .map(|set_action| set_action.into_inner().into())
+                    .collect(),
+                call: value.call.map(FrrRouteMapName::from),
+                exit_action: value.exit_action.map(|value| value.into_inner().into()),
+                custom_frr_config: Default::default(),
+            }
+        }
+    }
+
+    /// Add a list of Route Map Entries to a [`FrrConfig`].
+    ///
+    /// This method takes a list of Route Map Entries and adds them to given FRR configuration.
+    /// If a route map with the same name as at least one entry in the config exists in the FRR
+    /// configuration, then the *whole* route map will get overwritten with the route map from the
+    /// configuration.
+    pub fn build_frr_route_maps(
+        config: impl IntoIterator<Item = RouteMap>,
+        frr_config: &mut FrrConfig,
+    ) -> Result<(), anyhow::Error> {
+        let mut config_route_map: HashMap<FrrRouteMapName, Vec<FrrRouteMapEntry>> = HashMap::new();
+
+        for route_map in config.into_iter() {
+            let RouteMap::RouteMapEntry(route_map) = route_map;
+            let route_map_name = FrrRouteMapName::new(route_map.id.route_map_id.to_string());
+
+            if let Some(frr_route_map) = config_route_map.get_mut(&route_map_name) {
+                let idx =
+                    frr_route_map.partition_point(|element| element.seq <= route_map.id().order());
+                frr_route_map.insert(idx, route_map.into());
+            } else {
+                config_route_map.insert(route_map_name, vec![route_map.into()]);
+            }
+        }
+
+        for (name, entries) in config_route_map {
+            frr_config.routemaps.insert(name, entries);
+        }
+
+        Ok(())
+    }
+}
+
 pub mod api {
     //! API type for Route Map Entries.
     //!
-- 
2.47.3





  parent reply	other threads:[~2026-04-01 14:42 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-01 14:39 [PATCH access-control/cluster/network/proxmox{-ve-rs,-perl-rs} v2 00/34] Add support for route maps / prefix lists to SDN Stefan Hanreich
2026-04-01 14:39 ` [PATCH pve-cluster v2 01/34] cfs: add 'sdn/route-maps.cfg' to observed files Stefan Hanreich
2026-04-01 14:39 ` [PATCH pve-cluster v2 02/34] cfs: add 'sdn/prefix-lists.cfg' " Stefan Hanreich
2026-04-01 14:39 ` [PATCH pve-access-control v2 03/34] permissions: add ACL path for prefix-lists and route-maps Stefan Hanreich
2026-04-01 14:39 ` [PATCH proxmox-ve-rs v2 04/34] frr: add constructor to prefix list name Stefan Hanreich
2026-04-01 14:39 ` [PATCH proxmox-ve-rs v2 05/34] sdn-types: add common route-map helper types Stefan Hanreich
2026-04-02 13:36   ` Wolfgang Bumiller
2026-04-01 14:39 ` [PATCH proxmox-ve-rs v2 06/34] frr: change order type to u16 Stefan Hanreich
2026-04-01 14:39 ` [PATCH proxmox-ve-rs v2 07/34] frr: implement routemap match/set statements via adjacent tagging Stefan Hanreich
2026-04-01 14:39 ` [PATCH proxmox-ve-rs v2 08/34] frr: implement support for call and exit action Stefan Hanreich
2026-04-01 14:39 ` [PATCH proxmox-ve-rs v2 09/34] frr-templates: change route maps template to adapt to new frr types Stefan Hanreich
2026-04-01 14:39 ` [PATCH proxmox-ve-rs v2 10/34] ve-config: fabrics: adapt frr config generation Stefan Hanreich
2026-04-01 14:39 ` [PATCH proxmox-ve-rs v2 11/34] ve-config: add prefix list section config Stefan Hanreich
2026-04-01 14:39 ` [PATCH proxmox-ve-rs v2 12/34] ve-config: frr: implement frr config generation for prefix lists Stefan Hanreich
2026-04-01 14:39 ` [PATCH proxmox-ve-rs v2 13/34] ve-config: add route map section config Stefan Hanreich
2026-04-01 14:39 ` Stefan Hanreich [this message]
2026-04-01 14:39 ` [PATCH proxmox-ve-rs v2 15/34] ve-config: add prefix lists integration tests Stefan Hanreich
2026-04-01 14:39 ` [PATCH proxmox-ve-rs v2 16/34] ve-config: add route maps " Stefan Hanreich
2026-04-01 14:39 ` [PATCH proxmox-perl-rs v2 17/34] pve-rs: sdn: add route maps module Stefan Hanreich
2026-04-01 14:39 ` [PATCH proxmox-perl-rs v2 18/34] pve-rs: sdn: add prefix lists module Stefan Hanreich
2026-04-01 14:39 ` [PATCH proxmox-perl-rs v2 19/34] sdn: add prefix list / route maps to frr config generation helper Stefan Hanreich
2026-04-01 14:39 ` [PATCH pve-network v2 20/34] controller: bgp: evpn: adapt to new match / set frr config syntax Stefan Hanreich
2026-04-01 14:39 ` [PATCH pve-network v2 21/34] sdn: add prefix lists module Stefan Hanreich
2026-04-01 14:39 ` [PATCH pve-network v2 22/34] api2: add prefix list module Stefan Hanreich
2026-04-01 14:39 ` [PATCH pve-network v2 23/34] sdn: add route map module Stefan Hanreich
2026-04-01 14:39 ` [PATCH pve-network v2 24/34] api2: add route maps api module Stefan Hanreich
2026-04-01 14:39 ` [PATCH pve-network v2 25/34] api2: add route map module Stefan Hanreich
2026-04-01 14:39 ` [PATCH pve-network v2 26/34] api2: add route map entry module Stefan Hanreich
2026-04-01 14:39 ` [PATCH pve-network v2 27/34] evpn controller: add route_map_{in,out} parameter Stefan Hanreich
2026-04-01 14:39 ` [PATCH pve-network v2 28/34] bgp controller: allow configuring custom route maps Stefan Hanreich
2026-04-01 14:39 ` [PATCH pve-network v2 29/34] sdn: change detection for route maps / prefix lists Stefan Hanreich
2026-04-01 14:39 ` [PATCH pve-network v2 30/34] sdn: generate route map / prefix list configuration on sdn apply Stefan Hanreich
2026-04-01 14:39 ` [PATCH pve-network v2 31/34] tests: add simple route map test case Stefan Hanreich
2026-04-01 14:39 ` [PATCH pve-network v2 32/34] tests: add bgp evpn route map/prefix list testcase Stefan Hanreich
2026-04-01 14:39 ` [PATCH pve-network v2 33/34] tests: add route map with prefix " Stefan Hanreich
2026-04-01 14:39 ` [PATCH pve-network v2 34/34] tests: add exit node with custom route map testcase Stefan Hanreich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260401143957.386809-15-s.hanreich@proxmox.com \
    --to=s.hanreich@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal