public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Lukas Wagner <l.wagner@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [PATCH manager 3/3] api: backup: deprecate starttime and dow in create/update parameter schema
Date: Wed,  1 Apr 2026 16:09:02 +0200	[thread overview]
Message-ID: <20260401140903.364176-4-l.wagner@proxmox.com> (raw)
In-Reply-To: <20260401140903.364176-1-l.wagner@proxmox.com>

When creating and updating backup jobs, the both parameters will be
supported until further notice -- we only really should remove them in a
major update -- but it definitely makes sense to mark them as deprecated
in the parameter schema and document that these will be automatically
translated into a matching 'schedule'.

Signed-off-by: Lukas Wagner <l.wagner@proxmox.com>
---
 PVE/API2/Backup.pm | 16 ++++++++++++----
 1 file changed, 12 insertions(+), 4 deletions(-)

diff --git a/PVE/API2/Backup.pm b/PVE/API2/Backup.pm
index 0683748e..3bd85593 100644
--- a/PVE/API2/Backup.pm
+++ b/PVE/API2/Backup.pm
@@ -269,18 +269,22 @@ __PACKAGE__->register_method({
                 maxLength => 128,
                 optional => 1,
             },
+            # FIXME: MAJOR VERSION: Drop this deprecated parameter.
             starttime => {
                 type => 'string',
-                description => "Job Start time.",
+                description => "Deprecated: Use 'schedule' instead. Job Start time."
+                    . " 'starttime' and 'dow' will be converted into 'schedule' if used.",
                 pattern => '\d{1,2}:\d{1,2}',
                 typetext => 'HH:MM',
                 optional => 1,
             },
+            # FIXME: MAJOR VERSION: Drop this deprecated parameter.
             dow => {
                 type => 'string',
                 format => 'pve-day-of-week-list',
                 optional => 1,
-                description => "Day of week selection.",
+                description => "Deprecated: Use 'schedule' instead. Day of week selection."
+                    . " 'starttime' and 'dow' will be converted into 'schedule' if used.",
                 requires => 'starttime',
                 default => ALL_DAYS,
             },
@@ -497,19 +501,23 @@ __PACKAGE__->register_method({
                 maxLength => 128,
                 optional => 1,
             },
+            # FIXME: MAJOR VERSION: Drop this deprecated parameter.
             starttime => {
                 type => 'string',
-                description => "Job Start time.",
+                description => "Deprecated: Use 'schedule' instead. Job Start time."
+                    . " 'starttime' and 'dow' will be converted into 'schedule' if used.",
                 pattern => '\d{1,2}:\d{1,2}',
                 typetext => 'HH:MM',
                 optional => 1,
             },
+            # FIXME: MAJOR VERSION: Drop this deprecated parameter.
             dow => {
                 type => 'string',
                 format => 'pve-day-of-week-list',
                 optional => 1,
                 requires => 'starttime',
-                description => "Day of week selection.",
+                description => "Deprecated: Use 'schedule' instead. Day of week selection."
+                    . " 'starttime' and 'dow' will be converted into 'schedule' if used.",
             },
             delete => {
                 type => 'string',
-- 
2.47.3





  parent reply	other threads:[~2026-04-01 14:09 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-01 14:08 [PATCH manager 0/3] api: backup: drop/deprecate dow and starttime Lukas Wagner
2026-04-01 14:09 ` [PATCH manager 1/3] api: backup: drop starttime and dow from return schema Lukas Wagner
2026-04-01 14:09 ` [PATCH manager 2/3] api: backup: drop legacy starttime and dow from API response Lukas Wagner
2026-04-01 14:09 ` Lukas Wagner [this message]
2026-04-02 16:11 ` applied: [PATCH manager 0/3] api: backup: drop/deprecate dow and starttime Thomas Lamprecht

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260401140903.364176-4-l.wagner@proxmox.com \
    --to=l.wagner@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal