public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Lukas Wagner <l.wagner@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [PATCH manager 1/3] api: backup: drop starttime and dow from return schema
Date: Wed,  1 Apr 2026 16:09:00 +0200	[thread overview]
Message-ID: <20260401140903.364176-2-l.wagner@proxmox.com> (raw)
In-Reply-To: <20260401140903.364176-1-l.wagner@proxmox.com>

For backup jobs returned by the API, the `dow` and `starttime`
parameters are only ever set for legacy-jobs that are defined in the old
vzdump.cron configuration file. The newer backup jobs based on the
jobs.cfg file were introduced in [0]. Ever since then, any new or
updated backup job was stored in jobs.cfg, meaning that it is rather
unlikely to have any backup jobs in the old configuration file anyways,
from which subsequently follows that the 'dow' and 'starttime' params
will hardly ever be included in the response anyways. And even if a
legacy job is read from the old file, an appropriate 'schedule' key is
automatically synthesized from 'dow' and 'starttime'.

In summary:
  - 'dow' and 'starttime' will hardly ever be set
  - 'schedule' will ALWAYS be set
  - any client needed to understand the 'schedule' parameter since 7.1
    anyways

It should therefore be fine to just drop both old keys from the return
schema; this is a good chance to clean up some legacy cruft.

[0]: https://git.proxmox.com/?p=pve-manager.git;a=commitdiff;h=305921b1a

Suggested-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Signed-off-by: Lukas Wagner <l.wagner@proxmox.com>
---
 PVE/API2/Backup.pm | 15 ---------------
 1 file changed, 15 deletions(-)

diff --git a/PVE/API2/Backup.pm b/PVE/API2/Backup.pm
index 1d6d4257..2ab78834 100644
--- a/PVE/API2/Backup.pm
+++ b/PVE/API2/Backup.pm
@@ -129,21 +129,6 @@ my $backup_job_return_schema = PVE::VZDump::Common::json_config_properties({
         maxLength => 128,
         optional => 1,
     },
-    starttime => {
-        type => 'string',
-        description => "Job start-time (server timezone); deprecated and replaced by schedule.",
-        pattern => '\d{1,2}:\d{1,2}',
-        typetext => 'HH:MM',
-        optional => 1,
-    },
-    dow => {
-        type => 'string',
-        format => 'pve-day-of-week-list',
-        optional => 1,
-        description => "Day of week selection; deprecated and replaced by schedule.",
-        requires => 'starttime',
-        default => ALL_DAYS,
-    },
     enabled => {
         type => 'boolean',
         optional => 1,
-- 
2.47.3





  reply	other threads:[~2026-04-01 14:09 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-01 14:08 [PATCH manager 0/3] api: backup: drop/deprecate dow and starttime Lukas Wagner
2026-04-01 14:09 ` Lukas Wagner [this message]
2026-04-01 14:09 ` [PATCH manager 2/3] api: backup: drop legacy starttime and dow from API response Lukas Wagner
2026-04-01 14:09 ` [PATCH manager 3/3] api: backup: deprecate starttime and dow in create/update parameter schema Lukas Wagner
2026-04-02 16:11 ` applied: [PATCH manager 0/3] api: backup: drop/deprecate dow and starttime Thomas Lamprecht

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260401140903.364176-2-l.wagner@proxmox.com \
    --to=l.wagner@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal