public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Fiona Ebner <f.ebner@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [PATCH qemu-server] migration: print netdevice: only warn about missing host_mtu setting when unexpected
Date: Tue, 31 Mar 2026 16:46:03 +0200	[thread overview]
Message-ID: <20260331144738.856141-1-f.ebner@proxmox.com> (raw)

When the machine version is less than 10.0+pve1 and the MTU is 1500,
not having the host_mtu parameter is fully expected. Only log when the
missing host_mtu setting is not expected to avoid confusion. Reported
in the community forum [0].

[0]: https://forum.proxmox.com/threads/182156/

Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
---
 src/PVE/QemuServer.pm | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/PVE/QemuServer.pm b/src/PVE/QemuServer.pm
index fee93193..3e510e01 100644
--- a/src/PVE/QemuServer.pm
+++ b/src/PVE/QemuServer.pm
@@ -1386,7 +1386,12 @@ sub print_netdevice_full {
     } elsif (defined($mtu)) {
         my $msg_prefix = "netdev $netid: ignoring MTU '$mtu'";
         if ($migration_skip_host_mtu) {
-            log_warn("$msg_prefix, not used on the source side according to migration parameters");
+            # When the machine version is less than 10.0+pve1 and the MTU is 1500, not having the
+            # host_mtu parameter is fully expected. Only log when not expected to avoid confusion.
+            if (min_version($machine_version, 10, 0, 1) || $mtu != 1500) {
+                log_warn(
+                    "$msg_prefix, not used on the source side according to migration parameters");
+            }
         } elsif (!$net->{bridge}) {
             log_warn("$msg_prefix, no bridge configured");
         } else {
-- 
2.47.3





             reply	other threads:[~2026-03-31 14:47 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-31 14:46 Fiona Ebner [this message]
2026-03-31 18:41 ` applied: " Thomas Lamprecht

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260331144738.856141-1-f.ebner@proxmox.com \
    --to=f.ebner@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal