public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Fiona Ebner <f.ebner@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [PATCH storage v2 7/7] lvm plugin: schema: align description of 'tagged_only' with actual behavior
Date: Tue, 31 Mar 2026 13:49:55 +0200	[thread overview]
Message-ID: <20260331115011.102276-8-f.ebner@proxmox.com> (raw)
In-Reply-To: <20260331115011.102276-1-f.ebner@proxmox.com>

The only thing that the 'tagged_only' property affects is the
list_images() method and this has been the case since the option was
introduced 10 years ago with commit 7a9dd11 ("add tagged_only option
to LVM storage"). There are no other checks against using such
volumes if their name adheres to the vm-ID-XYZ schema. For example,
they can be accessed via 'pvesm free' and assigned to a VM with
'qm set'. If such checks are added, that should be done as part of a
major release to avoid breaking any existing setup. Document the
actual behavior for now.

Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
---

New in v2.

 src/PVE/Storage/LVMPlugin.pm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/PVE/Storage/LVMPlugin.pm b/src/PVE/Storage/LVMPlugin.pm
index b4cb0c5..ff8c5f4 100644
--- a/src/PVE/Storage/LVMPlugin.pm
+++ b/src/PVE/Storage/LVMPlugin.pm
@@ -440,7 +440,7 @@ sub properties {
             type => 'string',
         },
         tagged_only => {
-            description => "Only use logical volumes tagged with 'pve-vm-ID'.",
+            description => "Only list logical volumes tagged with 'pve-vm-ID'.",
             type => 'boolean',
         },
     };
-- 
2.47.3





      parent reply	other threads:[~2026-03-31 11:50 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-31 11:49 [PATCH-SERIES storage v2 0/7] lvm plugin: activation/renaming/tag improvements Fiona Ebner
2026-03-31 11:49 ` [PATCH storage v2 1/7] fix #7280: lvm plugin: rename: activate qcow2 volume to read snapshot info Fiona Ebner
2026-03-31 11:49 ` [PATCH storage v2 2/7] lvm plugin: rename: improve error message Fiona Ebner
2026-03-31 11:49 ` [PATCH storage v2 3/7] lvm plugin: rename: update tags when renaming Fiona Ebner
2026-03-31 11:49 ` [PATCH storage v2 4/7] lvm plugin: remove cryptic partial comment Fiona Ebner
2026-03-31 11:49 ` [PATCH storage v2 5/7] lvm plugin: activation: avoid extra variable Fiona Ebner
2026-03-31 11:49 ` [PATCH storage v2 6/7] fix #7143: ensure qcow2 volume (de)activation is limited to target volume chain Fiona Ebner
2026-03-31 11:49 ` Fiona Ebner [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260331115011.102276-8-f.ebner@proxmox.com \
    --to=f.ebner@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal