public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Fiona Ebner <f.ebner@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [PATCH storage v2 4/7] lvm plugin: remove cryptic partial comment
Date: Tue, 31 Mar 2026 13:49:52 +0200	[thread overview]
Message-ID: <20260331115011.102276-5-f.ebner@proxmox.com> (raw)
In-Reply-To: <20260331115011.102276-1-f.ebner@proxmox.com>

This partial comment was added with commit c8943a8 ("remove non used
parameter exclusive") back in 2015, but there is no explanation what
it means or what the fix me refers to, not even on the mailing list
[0]. Just remove the comment now after 10 years, to avoid confusing
people. If there really is something to fix, then it should resurface
as an actual issue.

There also seems to be a typo, since 'lvmchange' was a pre-LVM2
command to "change attributes of the logical volume manager" [1]
rather than individual LVs and even at the time of commit c8943a8, the
'lvchange' command was used by the activate_volume() method and there
is no further reference to 'lvmchange' in the pve-storage git history.

[0]: https://lists.proxmox.com/pipermail/pve-devel/2015-September/017233.html
[1]: https://gitlab.com/lvmteam/lvm2/-/commit/8ef93c756eecc2036f0c945c80972902f27970ca

Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
---

New in v2.

 src/PVE/Storage/LVMPlugin.pm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/PVE/Storage/LVMPlugin.pm b/src/PVE/Storage/LVMPlugin.pm
index cd4d07a..7ef148b 100644
--- a/src/PVE/Storage/LVMPlugin.pm
+++ b/src/PVE/Storage/LVMPlugin.pm
@@ -954,7 +954,7 @@ sub deactivate_storage {
 
 sub activate_volume {
     my ($class, $storeid, $scfg, $volname, $snapname, $cache) = @_;
-    #fix me lvmchange is not provided on
+
     my $path = $class->path($scfg, $volname, $storeid, $snapname);
 
     my $lvm_activate_mode = 'ey';
-- 
2.47.3





  parent reply	other threads:[~2026-03-31 11:50 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-31 11:49 [PATCH-SERIES storage v2 0/7] lvm plugin: activation/renaming/tag improvements Fiona Ebner
2026-03-31 11:49 ` [PATCH storage v2 1/7] fix #7280: lvm plugin: rename: activate qcow2 volume to read snapshot info Fiona Ebner
2026-03-31 11:49 ` [PATCH storage v2 2/7] lvm plugin: rename: improve error message Fiona Ebner
2026-03-31 11:49 ` [PATCH storage v2 3/7] lvm plugin: rename: update tags when renaming Fiona Ebner
2026-03-31 11:49 ` Fiona Ebner [this message]
2026-03-31 11:49 ` [PATCH storage v2 5/7] lvm plugin: activation: avoid extra variable Fiona Ebner
2026-03-31 11:49 ` [PATCH storage v2 6/7] fix #7143: ensure qcow2 volume (de)activation is limited to target volume chain Fiona Ebner
2026-03-31 11:49 ` [PATCH storage v2 7/7] lvm plugin: schema: align description of 'tagged_only' with actual behavior Fiona Ebner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260331115011.102276-5-f.ebner@proxmox.com \
    --to=f.ebner@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal