public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
* [RFC PATCH] frr: d/control: add proxmox-frr-templates dependency
@ 2026-03-31  9:00 Daniel Kral
  2026-03-31  9:15 ` Gabriel Goller
  0 siblings, 1 reply; 2+ messages in thread
From: Daniel Kral @ 2026-03-31  9:00 UTC (permalink / raw)
  To: pve-devel

proxmox-frr requires the jinja template files provided by
proxmox-frr-templates at compile time to build the crate.

Signed-off-by: Daniel Kral <d.kral@proxmox.com>
---
I've stumbled on this when the build for libpve-rs-perl failed because I
didn't have the package installed.

 proxmox-frr/debian/control | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/proxmox-frr/debian/control b/proxmox-frr/debian/control
index 265fa70..e918000 100644
--- a/proxmox-frr/debian/control
+++ b/proxmox-frr/debian/control
@@ -18,7 +18,8 @@ Build-Depends-Arch: cargo:native <!nocheck>,
  librust-serde-1+derive-dev <!nocheck>,
  librust-serde-repr-0.1+default-dev <!nocheck>,
  librust-thiserror-2+default-dev <!nocheck>,
- librust-tracing-0.1+default-dev <!nocheck>
+ librust-tracing-0.1+default-dev <!nocheck>,
+ proxmox-frr-templates <!nocheck>
 Maintainer: Proxmox Support Team <support@proxmox.com>
 Standards-Version: 4.7.2
 Vcs-Git: git://git.proxmox.com/git/proxmox-ve-rs.git
@@ -43,7 +44,8 @@ Depends:
  librust-serde-1+derive-dev,
  librust-serde-repr-0.1+default-dev,
  librust-thiserror-2+default-dev,
- librust-tracing-0.1+default-dev
+ librust-tracing-0.1+default-dev,
+ proxmox-frr-templates
 Provides:
  librust-proxmox-frr+default-dev (= ${binary:Version}),
  librust-proxmox-frr-0-dev (= ${binary:Version}),
-- 
2.47.3





^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [RFC PATCH] frr: d/control: add proxmox-frr-templates dependency
  2026-03-31  9:00 [RFC PATCH] frr: d/control: add proxmox-frr-templates dependency Daniel Kral
@ 2026-03-31  9:15 ` Gabriel Goller
  0 siblings, 0 replies; 2+ messages in thread
From: Gabriel Goller @ 2026-03-31  9:15 UTC (permalink / raw)
  To: Daniel Kral; +Cc: pve-devel

On 31.03.2026 11:00, Daniel Kral wrote:
> proxmox-frr requires the jinja template files provided by
> proxmox-frr-templates at compile time to build the crate.
> 
> Signed-off-by: Daniel Kral <d.kral@proxmox.com>
> ---
> I've stumbled on this when the build for libpve-rs-perl failed because I
> didn't have the package installed.
> 
>  proxmox-frr/debian/control | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/proxmox-frr/debian/control b/proxmox-frr/debian/control
> index 265fa70..e918000 100644
> --- a/proxmox-frr/debian/control
> +++ b/proxmox-frr/debian/control
> @@ -18,7 +18,8 @@ Build-Depends-Arch: cargo:native <!nocheck>,
>   librust-serde-1+derive-dev <!nocheck>,
>   librust-serde-repr-0.1+default-dev <!nocheck>,
>   librust-thiserror-2+default-dev <!nocheck>,
> - librust-tracing-0.1+default-dev <!nocheck>
> + librust-tracing-0.1+default-dev <!nocheck>,
> + proxmox-frr-templates <!nocheck>
>  Maintainer: Proxmox Support Team <support@proxmox.com>
>  Standards-Version: 4.7.2
>  Vcs-Git: git://git.proxmox.com/git/proxmox-ve-rs.git
> @@ -43,7 +44,8 @@ Depends:
>   librust-serde-1+derive-dev,
>   librust-serde-repr-0.1+default-dev,
>   librust-thiserror-2+default-dev,
> - librust-tracing-0.1+default-dev
> + librust-tracing-0.1+default-dev,
> + proxmox-frr-templates
>  Provides:
>   librust-proxmox-frr+default-dev (= ${binary:Version}),
>   librust-proxmox-frr-0-dev (= ${binary:Version}),
> -- 
> 2.47.3

Arghh, I had this at some point but it slipped out. Sorry about that!

LGTM, Consider:

Reviewed-by: Gabriel Goller <g.goller@proxmox.com>




^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2026-03-31  9:16 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-03-31  9:00 [RFC PATCH] frr: d/control: add proxmox-frr-templates dependency Daniel Kral
2026-03-31  9:15 ` Gabriel Goller

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal