public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Kefu Chai <k.chai@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [PATCH manager 1/1] pve8to9: fix package lookup empty result check
Date: Tue, 31 Mar 2026 08:41:19 +0800	[thread overview]
Message-ID: <20260331004119.707556-2-k.chai@proxmox.com> (raw)
In-Reply-To: <20260331004119.707556-1-k.chai@proxmox.com>

The empty result guard used two conditions that are always false for an
array reference:

  if (!defined $pkgs || $pkgs == 0) {

'$pkgs' from '[grep {...} @list]' is always defined, and '$pkgs == 0'
numifies the reference (memory address), which is never zero. The
diagnostic log_fail message was therefore never emitted when a package
was not found in the version list.

Replace with '!@$pkgs' to correctly test whether the array is empty.

Signed-off-by: Kefu Chai <k.chai@proxmox.com>
---
 PVE/CLI/pve8to9.pm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/PVE/CLI/pve8to9.pm b/PVE/CLI/pve8to9.pm
index 0c4b2343..afc4785e 100644
--- a/PVE/CLI/pve8to9.pm
+++ b/PVE/CLI/pve8to9.pm
@@ -175,7 +175,7 @@ my $get_pkg = sub {
     }
 
     my $pkgs = [grep { $_->{Package} eq $pkg } @$versions];
-    if (!defined $pkgs || $pkgs == 0) {
+    if (!@$pkgs) {
         log_fail("unable to determine installed $pkg version.");
         return undef;
     } else {
-- 
2.47.3





      reply	other threads:[~2026-03-31  0:41 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-31  0:41 [PATCH manager 0/1] " Kefu Chai
2026-03-31  0:41 ` Kefu Chai [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260331004119.707556-2-k.chai@proxmox.com \
    --to=k.chai@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal