From: Robin Christ <robin@rchrist.io>
To: pve-devel@lists.proxmox.com
Cc: Robin Christ <r.christ@partimus.com>
Subject: [PATCH ifupdown2 2/4] nlcache: Add missing link_set_mtu_dry_run method
Date: Mon, 30 Mar 2026 23:39:19 +0200 [thread overview]
Message-ID: <20260330213921.533853-3-robin@rchrist.io> (raw)
In-Reply-To: <20260330213921.533853-1-robin@rchrist.io>
From: Robin Christ <r.christ@partimus.com>
nlcache NetlinkListenerWithCache got a new link_set_mtu based on netlink at
some point, but never the dry run variant link_set_mtu_dry_run,
breaking dry runs
Signed-off-by: Robin Christ <r.christ@partimus.com>
---
...-missing-link_set_mtu_dry_run-method.patch | 25 +++++++++++++++++++
debian/patches/series | 1 +
2 files changed, 26 insertions(+)
create mode 100644 debian/patches/pve/0017-nlcache-add-missing-link_set_mtu_dry_run-method.patch
diff --git a/debian/patches/pve/0017-nlcache-add-missing-link_set_mtu_dry_run-method.patch b/debian/patches/pve/0017-nlcache-add-missing-link_set_mtu_dry_run-method.patch
new file mode 100644
index 0000000..f90dd78
--- /dev/null
+++ b/debian/patches/pve/0017-nlcache-add-missing-link_set_mtu_dry_run-method.patch
@@ -0,0 +1,25 @@
+From: Robin Christ <r.christ@partimus.com>
+Date: Mon, 30 Mar 2026 18:59:04 +0200
+Subject: nlcache: Add missing link_set_mtu_dry_run method
+
+nlcache NetlinkListenerWithCache got a new link_set_mtu based on netlink at some point, but never the dry run variant link_set_mtu_dry_run, breaking dry runs
+
+Signed-off-by: Robin Christ <r.christ@partimus.com>
+---
+ ifupdown2/lib/nlcache.py | 3 +++
+ 1 file changed, 3 insertions(+)
+
+diff --git a/ifupdown2/lib/nlcache.py b/ifupdown2/lib/nlcache.py
+index a92ac6f..2d37443 100644
+--- a/ifupdown2/lib/nlcache.py
++++ b/ifupdown2/lib/nlcache.py
+@@ -3331,6 +3331,9 @@ class NetlinkListenerWithCache(nllistener.NetlinkManagerWithListener, BaseObject
+
+ ###
+
++ def link_set_mtu_dry_run(self, ifname, mtu):
++ self.log_info_ifname_dry_run(ifname, "netlink: ip link set dev %s mtu %s" % (ifname, mtu))
++
+ """
+ Sets the MTU of the given link, updating the cache on success.
+
diff --git a/debian/patches/series b/debian/patches/series
index 8655369..45d92cb 100644
--- a/debian/patches/series
+++ b/debian/patches/series
@@ -17,3 +17,4 @@ upstream/0002-vxlan-add-support-for-IPv6-vxlan-local-tunnelip.patch
pve/0014-nlmanager-read-ipv6-devconf-disable_ipv6-attribute-t.patch
pve/0015-revert-addons-bond-warn-if-sub-interface-is-detected-on-bond-slave.patch
pve/0016-nlcache-fix-missing-nodad-option-in-addr_add_dry_run.patch
+pve/0017-nlcache-add-missing-link_set_mtu_dry_run-method.patch
--
2.47.3
next prev parent reply other threads:[~2026-03-30 21:48 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-30 21:39 [PATCH ifupdown2 0/4] Fix multiple Single VXLAN Devices in bridge and some dry-run fixes Robin Christ
2026-03-30 21:39 ` [PATCH ifupdown2 1/4] nlcache: Fix missing nodad option in addr_add_dry_run Robin Christ
2026-03-30 21:39 ` Robin Christ [this message]
2026-03-30 21:39 ` [PATCH ifupdown2 3/4] iproute2: Fix bridge_link_update_vni_filter for dry-run Robin Christ
2026-03-30 21:39 ` [PATCH ifupdown2 4/4] bridge: Fix multiple Single VXLAN Devices in bridge not having tunnel_info applied on first run Robin Christ
2026-03-31 8:18 ` Gabriel Goller
2026-03-31 11:45 ` Robin Christ
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260330213921.533853-3-robin@rchrist.io \
--to=robin@rchrist.io \
--cc=pve-devel@lists.proxmox.com \
--cc=r.christ@partimus.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox