From: Kefu Chai <k.chai@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: Re: [PATCH manager] ceph: init: clean up deprecated pg_bits parameter
Date: Sat, 28 Mar 2026 19:31:26 +0800 [thread overview]
Message-ID: <20260328113126.1144445-1-k.chai@proxmox.com> (raw)
In-Reply-To: <9bb47f57-f91d-4090-8b02-63014549686a@proxmox.com>
Thanks Maximiliano for the review, and Thomas for catching the API
compatibility issue.
Thomas is absolutely right that this is a breaking API change. I was
thinking about it through a Ceph lens, where `main` is a development
branch and releases are cut from stable branches — so removing a
deprecated parameter from `main` wouldn't affect any released version.
Proxmox VE's release model is different: `master` is the release branch
for the current major version, meaning API changes on `master` affect
users immediately without a major version boundary as a natural
breakpoint. Good to have that clarified.
I've submitted v2 that keeps `pg_bits` as a documented no-op (with a
TODO to remove it in PVE 10) while still dropping the dead-code
comments:
https://lore.proxmox.com/pve-devel/20260328112307.1131390-1-k.chai@proxmox.com/
next prev parent reply other threads:[~2026-03-28 11:31 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-25 4:31 [PATCH manager] ceph: init: drop " Kefu Chai
2026-03-26 11:45 ` Maximiliano Sandoval
2026-03-26 12:55 ` Thomas Lamprecht
2026-03-28 11:31 ` Kefu Chai [this message]
2026-03-28 11:24 ` superseded: [PATCH manager] ceph: init: clean up " Kefu Chai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260328113126.1144445-1-k.chai@proxmox.com \
--to=k.chai@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox