From: Fiona Ebner <f.ebner@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [PATCH proxmox-perltidy] use more explicit --cuddled-blocks rather than --cuddled-else
Date: Fri, 27 Mar 2026 14:17:08 +0100 [thread overview]
Message-ID: <20260327132234.123474-1-f.ebner@proxmox.com> (raw)
The --cuddled-else flag is equivalent to --cuddled-blocks, but might
wrongly suggest that it only applies to else (and elsif). While those
are the most relevant ones for the Proxmox codebases, there are a few
other ones (see 'man perltidy'). Using --cuddled-blocks also better
suggests that the --cuddled-block-list option is a modifier that only
takes effect when --cuddled-blocks itself is present.
Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
---
src/perltidyrc | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/perltidyrc b/src/perltidyrc
index 300cf81..4299f29 100644
--- a/src/perltidyrc
+++ b/src/perltidyrc
@@ -70,7 +70,7 @@
--maximum-consecutive-blank-lines=1 # hard-code the default
# Control structure formatting
---cuddled-else # avoid extra line for else
+--cuddled-blocks # avoid extra line for else, elsif, ...
--cuddled-block-list=sort,map,grep # also cuddle sort, map and grep over standard else/elsif/...
--keyword-group-blanks-inside
--
2.47.3
reply other threads:[~2026-03-27 13:22 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260327132234.123474-1-f.ebner@proxmox.com \
--to=f.ebner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox