From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [PATCH qemu-server 4/4] qga: rename guest-fsfreeze to freeze-fs
Date: Wed, 25 Mar 2026 21:49:18 +0100 [thread overview]
Message-ID: <20260325210021.3789748-5-t.lamprecht@proxmox.com> (raw)
In-Reply-To: <20260325210021.3789748-1-t.lamprecht@proxmox.com>
These settings are already in the (QEMU guest) agent property, and we
do not use the guest- prefix for any of the existing properties
(fstrim or freeze-fs-on-backup), and moving freeze-fs-on-backup to a
generic variant is less confusing if one just drops the "-on-backup"
part, i.e. no point in inventing a new name schema just for the sake
of it.
We already rolled this the guest-fsfreeze name to pve-test, so lets
add an alias, but as we do not provide API stability guarantees for
test packages this is really just for convenience for anybody that
tested this, I'm more than fine with dropping such a (never stable)
released key again on a major release with the respective upgrade
check in our pveXtoY tool.
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
---
src/PVE/QemuServer/Agent.pm | 7 ++++++-
src/test/cfg2cmd/qga-fs-freeze.conf | 2 +-
2 files changed, 7 insertions(+), 2 deletions(-)
diff --git a/src/PVE/QemuServer/Agent.pm b/src/PVE/QemuServer/Agent.pm
index c0315a03..60ee38c8 100644
--- a/src/PVE/QemuServer/Agent.pm
+++ b/src/PVE/QemuServer/Agent.pm
@@ -38,9 +38,14 @@ our $agent_fmt = {
'freeze-fs-on-backup' => {
type => 'boolean',
optional => 1,
- alias => 'guest-fsfreeze', # keep for old backup restore compatibility
+ alias => 'freeze-fs', # keep for old backup restore compatibility
},
'guest-fsfreeze' => {
+ type => 'boolean',
+ optional => 1,
+ alias => 'freeze-fs', # TODO: was only on test repo, drop with PVE 10.
+ },
+ 'freeze-fs' => {
description => "Freeze guest filesystems through QGA for consistent disk state on"
. " operations such as snapshots, backups, replications and clones.",
verbose_description =>
diff --git a/src/test/cfg2cmd/qga-fs-freeze.conf b/src/test/cfg2cmd/qga-fs-freeze.conf
index c32e143e..809b7d43 100644
--- a/src/test/cfg2cmd/qga-fs-freeze.conf
+++ b/src/test/cfg2cmd/qga-fs-freeze.conf
@@ -1,2 +1,2 @@
# TEST: Ensure agent sub-properties do not affect the QEMU command line.
-agent: 1,guest-fsfreeze=1
+agent: 1,freeze-fs=1
--
2.47.3
next prev parent reply other threads:[~2026-03-25 21:00 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-25 20:49 [PATCH qemu-server 0/4] rework fs-freeze agent property Thomas Lamprecht
2026-03-25 20:49 ` [PATCH qemu-server 1/4] agent: add should_fs_freeze helper Thomas Lamprecht
2026-03-25 20:49 ` [PATCH qemu-server 2/4] agent: treat freeze-fs-on-backup as alias for guest-fsfreeze Thomas Lamprecht
2026-03-25 20:49 ` [PATCH qemu-server 3/4] tests: cfg2cmd: add agent guest-fsfreeze config tests Thomas Lamprecht
2026-03-25 20:49 ` Thomas Lamprecht [this message]
2026-03-25 21:35 ` superseded: [PATCH qemu-server 0/4] rework fs-freeze agent property Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260325210021.3789748-5-t.lamprecht@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox