public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
* [PATCH common 0/1] Silence non-portable hexadecimal warning
@ 2026-03-24 10:02 Laurent Corbes
  2026-03-24 10:02 ` [PATCH common 1/1] fix #7445: Silence non-portable hexadecimal Laurent Corbes
  0 siblings, 1 reply; 2+ messages in thread
From: Laurent Corbes @ 2026-03-24 10:02 UTC (permalink / raw)
  To: pve-devel; +Cc: Laurent Corbes

Silence WARN logs about non-portable hexadecimal number in tasks UPID.

As explained in the code this is not an issue and can be discarded,
however this is flooding the logs and generating a few GB of garbage 
logs in the system 


Laurent Corbes (1):
  fix #7445: Silence non-portable hexadecimal

 src/PVE/UPID.pm | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

-- 
2.43.0




^ permalink raw reply	[flat|nested] 2+ messages in thread

* [PATCH common 1/1] fix #7445: Silence non-portable hexadecimal
  2026-03-24 10:02 [PATCH common 0/1] Silence non-portable hexadecimal warning Laurent Corbes
@ 2026-03-24 10:02 ` Laurent Corbes
  0 siblings, 0 replies; 2+ messages in thread
From: Laurent Corbes @ 2026-03-24 10:02 UTC (permalink / raw)
  To: pve-devel; +Cc: Laurent Corbes

Fix a warning about non-portable perl hexadecimal number. This is
knowned to be ok, but this flood the logs with a lot of garbage
messages.

Signed-off-by: Laurent Corbes <laurent.corbes@enix.fr>
---
 src/PVE/UPID.pm | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/PVE/UPID.pm b/src/PVE/UPID.pm
index 1cb671d..b914b90 100644
--- a/src/PVE/UPID.pm
+++ b/src/PVE/UPID.pm
@@ -39,8 +39,8 @@ sub decode($upid, $noerr = 0) {
             node => $1,
             pid => hex($3),
             # NOTE: for 9-digit hex-number perl warns about non-portable, but it still works as
-            # asserted by a test case, we could silence the WARN handler or use Math::BigInt?
-            pstart => hex($4),
+            # asserted by a test case, so we silence the WARN
+            pstart => do { no warnings 'portable'; hex($4) },
             starttime => hex($5),
             type => $6,
             id => $7,
-- 
2.43.0




^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2026-03-24 10:03 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-03-24 10:02 [PATCH common 0/1] Silence non-portable hexadecimal warning Laurent Corbes
2026-03-24 10:02 ` [PATCH common 1/1] fix #7445: Silence non-portable hexadecimal Laurent Corbes

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal