From: Hannes Laimer <h.laimer@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [PATCH pve-apiclient] pass parameters for DELETE requests as query string
Date: Wed, 18 Mar 2026 14:22:53 +0100 [thread overview]
Message-ID: <20260318132253.177837-1-h.laimer@proxmox.com> (raw)
The DELETE handler silently dropped all parameters, making it impossible
to call API endpoints that require them.
Encode parameters as query string, the same way GET requests do.
Signed-off-by: Hannes Laimer <h.laimer@proxmox.com>
---
src/PVE/APIClient/LWP.pm | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/PVE/APIClient/LWP.pm b/src/PVE/APIClient/LWP.pm
index d8472f7..607cdf1 100755
--- a/src/PVE/APIClient/LWP.pm
+++ b/src/PVE/APIClient/LWP.pm
@@ -332,6 +332,7 @@ sub call {
);
} elsif ($method eq 'DELETE') {
+ $uri->query_form($param) if $param;
$response = $ua->request(HTTP::Request::Common::DELETE($uri));
} else {
raise("method $method not implemented\n");
--
2.47.3
reply other threads:[~2026-03-18 13:23 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260318132253.177837-1-h.laimer@proxmox.com \
--to=h.laimer@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox