public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Shannon Sterz <s.sterz@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [PATCH cluster v4 0/2] pmxcfs fix backup directory permissions
Date: Wed, 18 Mar 2026 12:11:09 +0100	[thread overview]
Message-ID: <20260318111111.114933-1-s.sterz@proxmox.com> (raw)

Changelog
---------

changes since v3 (thanks @ Thomas Lamprecht):
* moved changing the permissions of the backup directory when creating
  a backup to commit #1
* use in-built `rename` instead of `File::Copy::move`

changes since v2 (thanks @ Thomas Lamprecht):
* use chmod to always set the MODE of the backup directory before
  backing up.
* rotate the old config.db out of the way of the new one so we can
  continue a cluster join even if a backup fails.

changes since v1 (thanks @ Thomas Lamprecht):
* added a patch fixing the mkdir call in `cfs_backup_database`
* version guarded the permission fix up in the post install hook
* dropped the `-R` flag provided to the `chmod` call in the postinst
  hook (it did not provide any extra security and made lintian complain)

Shannon Sterz (2):
  pmxcfs: remove world-readable permissions from backups
  pmxcfs: don't abort join when backup fails and keep old config
    database

 debian/pve-cluster.dirs     |  1 +
 debian/pve-cluster.postinst |  8 ++++++++
 src/PVE/Cluster.pm          | 10 ++++++++--
 src/PVE/Cluster/Setup.pm    |  5 +++--
 4 files changed, 20 insertions(+), 4 deletions(-)

--
2.47.3





             reply	other threads:[~2026-03-18 11:11 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-18 11:11 Shannon Sterz [this message]
2026-03-18 11:11 ` [PATCH cluster v4 1/2] pmxcfs: remove world-readable permissions from backups Shannon Sterz
2026-03-18 11:11 ` [PATCH cluster v4 2/2] pmxcfs: don't abort join when backup fails and keep old config database Shannon Sterz
2026-03-18 14:27 ` applied: [PATCH cluster v4 0/2] pmxcfs fix backup directory permissions Thomas Lamprecht

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260318111111.114933-1-s.sterz@proxmox.com \
    --to=s.sterz@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal