public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Maximiliano Sandoval <m.sandoval@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [PATCH container/qemu-server v3 0/2] api: clone: print a message with new VMID
Date: Mon, 16 Mar 2026 13:38:17 +0100	[thread overview]
Message-ID: <20260316123820.333308-1-m.sandoval@proxmox.com> (raw)

Note that when creating linked clones we do not update the creation time (commits)
in the config.

When cloning two VMs from a template (created with "vanilla" settings),
if one uses the same 'name' for both clones, then the only differences
between the linked clones that could be used to tell them apart are the
MAC address, the VM id, smbios UUID, and the vmgenid, all of which are
randomly generated.

I think it makes sense to update the creation time too. But for now,
being able to tell from the task log which VM correspond to which
qmclone task would be an improvement already.

Tested:
 - create a template with id 101
 - running: qm clone 101 206 --full 0, and checking its output
   creating a clone of 101 with ID 206
   create linked clone of drive scsi0 (local-lvm:base-101-disk-0)

Differences from v2:
 - s/creating a clone of $vmid/creating a clone of VM $vmi
 - Add a similar line to pve-container's clone 

Differences from v1:
 - Moved the message to the start of $clonefn


qemu-server:

Maximiliano Sandoval (1):
  api: qmclone: print a message with new VMID

 src/PVE/API2/Qemu.pm | 3 +++
 1 file changed, 3 insertions(+)


pve-container:

Maximiliano Sandoval (1):
  api: vm_clone: print a message with new VMID

 src/PVE/API2/LXC.pm | 2 ++
 1 file changed, 2 insertions(+)


Summary over all repositories:
  2 files changed, 5 insertions(+), 0 deletions(-)

-- 
Generated by murpp 0.10.0




             reply	other threads:[~2026-03-16 12:38 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-16 12:38 Maximiliano Sandoval [this message]
2026-03-16 12:38 ` [PATCH qemu-server v3 1/2] api: qmclone: " Maximiliano Sandoval
2026-03-16 12:38 ` [PATCH container v3 2/2] api: vm_clone: " Maximiliano Sandoval
2026-03-16 14:15 ` applied: [PATCH container/qemu-server v3 0/2] api: clone: " Fiona Ebner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260316123820.333308-1-m.sandoval@proxmox.com \
    --to=m.sandoval@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal