public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Maximiliano Sandoval <m.sandoval@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [PATCH qemu-server] api: qmclone: print a message with new VMID
Date: Mon, 16 Mar 2026 10:06:59 +0100	[thread overview]
Message-ID: <20260316090712.106468-1-m.sandoval@proxmox.com> (raw)

When doing a linked clone of a template, the task log, journal, nor the
UPID of the task will log the VMID of the newly created VM.

We add a log message right before writing the config. This affects both
full and linked clones.

Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
---

Notes:
    Note that when creating linked clones we do not update the creation time
    in the config.
    
    When cloning two VMs from a template (created with "vanilla" settings),
    if one uses the same 'name' for both clones, then the only differences
    between the linked clones that could be used to tell them apart are the
    MAC address, the VM id, smbios UUID, and the vmgenid, all of which are
    randomly generated.
    
    I think it makes sense to update the creation time too. But for now,
    being able to tell from the task log which VM correspond to which
    qmclone task would be an improvement already.
    
    Tested:
     - create a template with id 101
     - running qm clone 101 202 --full 0 and checked the output:
    
       create linked clone of drive scsi0 (local-lvm:base-101-disk-0)
       writing configuration of cloned VM with ID 202

 src/PVE/API2/Qemu.pm | 1 +
 1 file changed, 1 insertion(+)

diff --git a/src/PVE/API2/Qemu.pm b/src/PVE/API2/Qemu.pm
index 1e226f6f..43e56837 100644
--- a/src/PVE/API2/Qemu.pm
+++ b/src/PVE/API2/Qemu.pm
@@ -4589,6 +4589,7 @@ __PACKAGE__->register_method({
                     delete $newconf->{pending};
                 }
 
+                print("writing configuration of clone with ID $newid\n");
                 PVE::QemuConfig->write_config($newid, $newconf);
 
                 PVE::QemuServer::Network::create_ifaces_ipams_ips($newconf, $newid);
-- 
2.47.3





             reply	other threads:[~2026-03-16  9:07 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-16  9:06 Maximiliano Sandoval [this message]
2026-03-16  9:35 ` Fiona Ebner
2026-03-16 10:16   ` superseded: " Maximiliano Sandoval

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260316090712.106468-1-m.sandoval@proxmox.com \
    --to=m.sandoval@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal