public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Daniel Herzig <d.herzig@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [RFC PATCH qemu-server 2/4] drive: ignore 'dismissable' parameter for everything but CD-ROMs
Date: Fri, 13 Mar 2026 14:12:04 +0100	[thread overview]
Message-ID: <20260313131206.277195-3-d.herzig@proxmox.com> (raw)
In-Reply-To: <20260313131206.277195-1-d.herzig@proxmox.com>

Signed-off-by: Daniel Herzig <d.herzig@proxmox.com>
---
 src/PVE/QemuServer/Drive.pm | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/src/PVE/QemuServer/Drive.pm b/src/PVE/QemuServer/Drive.pm
index 8539a1d3..43f89aae 100644
--- a/src/PVE/QemuServer/Drive.pm
+++ b/src/PVE/QemuServer/Drive.pm
@@ -854,6 +854,8 @@ sub parse_drive {
     if ($res->{media} && ($res->{media} eq 'cdrom')) {
         return if $res->{snapshot} || $res->{format};
         return if $res->{interface} eq 'virtio';
+    } else {
+	return if $res->{dismissable};
     }
 
     if (my $size = $res->{size}) {
-- 
2.47.3




  parent reply	other threads:[~2026-03-13 13:12 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-13 13:12 [RFC PATCH qemu-server 0/4] allow VMs to start with missing CD-ROM Daniel Herzig
2026-03-13 13:12 ` [RFC PATCH qemu-server 1/4] drive: Introduce parameter to mark CD-ROM as dissmissable Daniel Herzig
2026-03-13 13:12 ` Daniel Herzig [this message]
2026-03-13 13:12 ` [RFC PATCH qemu-server 3/4] introduce sub 'activate_current_vm_volumes' Daniel Herzig
2026-03-13 13:12 ` [RFC PATCH qemu-server 4/4] integrate new " Daniel Herzig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260313131206.277195-3-d.herzig@proxmox.com \
    --to=d.herzig@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal