public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
* [PATCH pve-manager v3 0/2] fix #7300: acl path include pre-generated zones and fabrics
@ 2026-03-13 12:26 David Riley
  2026-03-13 12:26 ` [PATCH pve-manager v3 1/2] ui: replace var with let David Riley
  2026-03-13 12:26 ` [PATCH pve-manager v3 2/2] fix #7300: acl path include pre-generated zones and fabrics David Riley
  0 siblings, 2 replies; 3+ messages in thread
From: David Riley @ 2026-03-13 12:26 UTC (permalink / raw)
  To: pve-devel; +Cc: David Riley

Thanks for the feedback.

Differences from v2:
* moved var to let conversion to a seperate commit
* using record.get instead of direct data access

Differences from v1:
* Add signature 

David Riley (2):
  ui: replace var with let
  fix #7300: acl path include pre-generated zones and fabrics

 www/manager6/data/PermPathStore.js | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

-- 
2.47.3




^ permalink raw reply	[flat|nested] 3+ messages in thread

* [PATCH pve-manager v3 1/2] ui: replace var with let
  2026-03-13 12:26 [PATCH pve-manager v3 0/2] fix #7300: acl path include pre-generated zones and fabrics David Riley
@ 2026-03-13 12:26 ` David Riley
  2026-03-13 12:26 ` [PATCH pve-manager v3 2/2] fix #7300: acl path include pre-generated zones and fabrics David Riley
  1 sibling, 0 replies; 3+ messages in thread
From: David Riley @ 2026-03-13 12:26 UTC (permalink / raw)
  To: pve-devel; +Cc: David Riley

Signed-off-by: David Riley <d.riley@proxmox.com>
---

Notes:
    Differences from v2:
    * moved var to let conversion to a seperate commit
    
    Differences from v1:
    * Add signature

 www/manager6/data/PermPathStore.js | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/www/manager6/data/PermPathStore.js b/www/manager6/data/PermPathStore.js
index c7ec4231..0a98846b 100644
--- a/www/manager6/data/PermPathStore.js
+++ b/www/manager6/data/PermPathStore.js
@@ -22,7 +22,7 @@ Ext.define('PVE.data.PermPathStore', {
     ],
 
     constructor: function (config) {
-        var me = this;
+        let me = this;
 
         config = config || {};
 
-- 
2.47.3




^ permalink raw reply	[flat|nested] 3+ messages in thread

* [PATCH pve-manager v3 2/2] fix #7300: acl path include pre-generated zones and fabrics
  2026-03-13 12:26 [PATCH pve-manager v3 0/2] fix #7300: acl path include pre-generated zones and fabrics David Riley
  2026-03-13 12:26 ` [PATCH pve-manager v3 1/2] ui: replace var with let David Riley
@ 2026-03-13 12:26 ` David Riley
  1 sibling, 0 replies; 3+ messages in thread
From: David Riley @ 2026-03-13 12:26 UTC (permalink / raw)
  To: pve-devel; +Cc: David Riley

Permission Path selection will show:
'/sdn/zones/<zone>'
'/sdn/fabrics/<fabric>'

The case 'network' is used because this will act as the top-level
resource for all networking entities (including SDN).

see: https://git.proxmox.com/?p=pve-manager.git;a=commit;h=9ac04d9572a458aeb891feb9b695d793cf7b122d
Signed-off-by: David Riley <d.riley@proxmox.com>
---

Notes:
    Differences from v2:
    * using record.get instead of direct data access
    
    Differences from v1:
    * Add signature

 www/manager6/data/PermPathStore.js | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/www/manager6/data/PermPathStore.js b/www/manager6/data/PermPathStore.js
index 0a98846b..33e4cb21 100644
--- a/www/manager6/data/PermPathStore.js
+++ b/www/manager6/data/PermPathStore.js
@@ -36,6 +36,9 @@ Ext.define('PVE.data.PermPathStore', {
                 case 'node':
                     path = '/nodes/' + record.get('text');
                     break;
+                case 'network':
+                    path = '/sdn/' + record.get('network-type') + 's/' + record.get('network');
+                    break;
                 case 'qemu':
                     path = '/vms/' + record.get('vmid');
                     break;
-- 
2.47.3




^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2026-03-13 12:26 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-03-13 12:26 [PATCH pve-manager v3 0/2] fix #7300: acl path include pre-generated zones and fabrics David Riley
2026-03-13 12:26 ` [PATCH pve-manager v3 1/2] ui: replace var with let David Riley
2026-03-13 12:26 ` [PATCH pve-manager v3 2/2] fix #7300: acl path include pre-generated zones and fabrics David Riley

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal