From: Maximiliano Sandoval <m.sandoval@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [PATCH manager v2 0/7] ui: qga: add checkbox for guest-fsfreeze
Date: Fri, 13 Mar 2026 10:55:26 +0100 [thread overview]
Message-ID: <20260313095534.79526-1-m.sandoval@proxmox.com> (raw)
Something that was missing from Fiona's comments was giving the "hint"
CSS class to the "Deprecated" part of the old checkbox's label. I was
not sure how to make that work in ExtJS.
The migration would work as follows:
- The new key takes preference over the old one so using the old one is OK.
- If the key is in the config file and explicitly disabled then the old
checkbox would be displayed
- But we delete the deprecated key from the config if it was explicitly
enabled (it is the default) after performing any change
One could additionally do some extra work where setting the new key will also
set the old value, but for the sake of simplicity I think this is a good start.
I added to my TODO list to add a migration check to the pve9to10 script.
Differences from v1:
- Rephrased the user-facing strings
- Fix a typo in a commit message
- Expand some commit messages
- Hide the checkbox not only if it was undefined, but also if it was
explicitly set to the default value
Maximiliano Sandoval (7):
ui: utils: support guest-fsfreeze at render_qga_features
ui: qga: merge translatable string
ui: qga: move freeze-fs-on-backup to advanced opts
ui: qga: note that freeze-fs-on-backup is deprecated
ui: qga: add checkbox for guest-fsfreeze
ui: qga: call parameter me instead of this
ui: qga: hide freeze-fs-on-backup conditionally
www/manager6/Utils.js | 2 +
www/manager6/form/AgentFeatureSelector.js | 72 ++++++++++++++++++++---
2 files changed, 66 insertions(+), 8 deletions(-)
--
2.47.3
next reply other threads:[~2026-03-13 9:55 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-13 9:55 Maximiliano Sandoval [this message]
2026-03-13 9:55 ` [PATCH manager v2 1/7] ui: utils: support guest-fsfreeze at render_qga_features Maximiliano Sandoval
2026-03-13 9:55 ` [PATCH manager v2 2/7] ui: qga: merge translatable string Maximiliano Sandoval
2026-03-13 9:55 ` [PATCH manager v2 3/7] ui: qga: move freeze-fs-on-backup to advanced opts Maximiliano Sandoval
2026-03-13 9:55 ` [PATCH manager v2 4/7] ui: qga: note that freeze-fs-on-backup is deprecated Maximiliano Sandoval
2026-03-13 9:55 ` [PATCH manager v2 5/7] ui: qga: add checkbox for guest-fsfreeze Maximiliano Sandoval
2026-03-16 21:41 ` Thomas Lamprecht
2026-03-13 9:55 ` [PATCH manager v2 6/7] ui: qga: call parameter me instead of this Maximiliano Sandoval
2026-03-13 9:55 ` [PATCH manager v2 7/7] ui: qga: hide freeze-fs-on-backup conditionally Maximiliano Sandoval
2026-03-16 21:37 ` Thomas Lamprecht
2026-03-16 15:29 ` applied: [PATCH manager v2 0/7] ui: qga: add checkbox for guest-fsfreeze Fiona Ebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260313095534.79526-1-m.sandoval@proxmox.com \
--to=m.sandoval@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox