public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Maximiliano Sandoval <m.sandoval@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [PATCH qemu-server v2 0/3] memory: add verbose_description to NUMA policy
Date: Thu, 12 Mar 2026 15:54:19 +0100	[thread overview]
Message-ID: <20260312145423.434537-1-m.sandoval@proxmox.com> (raw)

Adds a more flavorful description to the NUMA policy option based on
both qemu and the kernel's documentation. For now we simply paste the
contents of the `qemu-system-x86_64(1)` manual.

One open question is if there is any precedent for URIs in verbose
descriptions.

This came up in a couple of cases in enterprise support where
information was requested regarding the NUMA policy.

Regarding the 'default' value. NUMA policies were added on our side at
2ed5d5724 but there is no mention of why the 'default' policy is not
used as a default. On QEMU's side the first appearance of policies was a
2.1.0 (Aug 2014) and there was a 'default' value at that stage.

While one could use the 'default' policy when the property is not set, I
personally would prefer if "not setting the key in the config" can be
represented by an explicit value in the config.

What was tested:
 - Create a VM with 2048 MiB of ram and 1 CPU with numa enabled
 - Ran:
  - qm set 100 --numa0 cpus=0,memory=2048,hostnodes=0
  - qm set 100 --numa0 cpus=0,memory=2048,hostnodes=0,policy=default
  - qm set 100 --numa0 cpus=0,memory=2048,hostnodes=0,policy=bind
 - Verify in each case that the memory-backend-ram has the right policy
  in the qm showcmd 100 output

Differences from v1:
 - Add more to the commit messages
 - sed s/numa/NUMA
 - Read default value from the schema directly
 - Sneak a commit fixing the unit in a comment
 - Say what was tested in cover letter
 - Explain why a default value was added to the schema instead of just
   using it instead of dying in the cover letter

Maximiliano Sandoval (3):
  memory: add verbose_description to NUMA policy
  memory: add default NUMA allocation policy
  memory: fix unit in heuristic comment

 src/PVE/QemuServer/Memory.pm | 19 +++++++++++++++----
 1 file changed, 15 insertions(+), 4 deletions(-)

-- 
2.47.3





             reply	other threads:[~2026-03-12 14:54 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-12 14:54 Maximiliano Sandoval [this message]
2026-03-12 14:54 ` [PATCH qemu-server v2 1/3] " Maximiliano Sandoval
2026-03-12 14:54 ` [PATCH qemu-server v2 2/3] memory: add default NUMA allocation policy Maximiliano Sandoval
2026-03-12 14:54 ` [PATCH qemu-server v2 3/3] memory: fix unit in heuristic comment Maximiliano Sandoval

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260312145423.434537-1-m.sandoval@proxmox.com \
    --to=m.sandoval@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal