From: Arthur Bied-Charreton <a.bied-charreton@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [PATCH pve-manager] fix #7337: Keep track of deep link on OpenID login
Date: Thu, 12 Mar 2026 11:12:27 +0100 [thread overview]
Message-ID: <20260312101227.212668-1-a.bied-charreton@proxmox.com> (raw)
Previously, when opening a deep link without being logged into PVE, the
hash was getting lost, redirecting the user to / instead of
/#<deeplink>.
Store `window.location.hash` in sessionStorage (per-tab storage) before
redirecting to the login URL, and add it to `Ext.History` after successful
login to direct the user to the deeplink they opened.
Signed-off-by: Arthur Bied-Charreton <a.bied-charreton@proxmox.com>
---
www/manager6/Workspace.js | 5 +++++
www/manager6/window/LoginWindow.js | 1 +
2 files changed, 6 insertions(+)
diff --git a/www/manager6/Workspace.js b/www/manager6/Workspace.js
index b8061c2a..0f0e6ffb 100644
--- a/www/manager6/Workspace.js
+++ b/www/manager6/Workspace.js
@@ -49,6 +49,11 @@ Ext.define('PVE.Workspace', {
handler: function (data) {
me.login = null;
me.updateLoginData(data);
+ let deeplink = sessionStorage.getItem('openid-deeplink');
+ if (deeplink) {
+ sessionStorage.removeItem('openid-deeplink');
+ Ext.History.add(deeplink);
+ }
Proxmox.Utils.checked_command(Ext.emptyFn); // display subscription status
},
});
diff --git a/www/manager6/window/LoginWindow.js b/www/manager6/window/LoginWindow.js
index 324861ec..aacb8f2f 100644
--- a/www/manager6/window/LoginWindow.js
+++ b/www/manager6/window/LoginWindow.js
@@ -50,6 +50,7 @@ Ext.define('PVE.window.LoginWindow', {
if (this.getViewModel().data.openid === true) {
const redirectURL = location.origin;
+ sessionStorage.setItem('openid-deeplink', window.location.hash);
Proxmox.Utils.API2Request({
url: '/api2/extjs/access/openid/auth-url',
params: {
--
2.47.3
next reply other threads:[~2026-03-12 10:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-12 10:12 Arthur Bied-Charreton [this message]
2026-03-12 10:49 ` Arthur Bied-Charreton
2026-03-12 13:43 ` applied: " Dominik Csapak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260312101227.212668-1-a.bied-charreton@proxmox.com \
--to=a.bied-charreton@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox