public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Fiona Ebner <f.ebner@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [RFC firewall 3/3] d/pve-firewall.triggers: drop superfluous pve-api-updates activation
Date: Wed, 11 Mar 2026 11:54:26 +0100	[thread overview]
Message-ID: <20260311105524.50117-4-f.ebner@proxmox.com> (raw)
In-Reply-To: <20260311105524.50117-1-f.ebner@proxmox.com>

pve-manager commit 27d1db3a ("triggers: add path-based trigger
interest") added a path-based interest and states:

> to avoid the need to mark every package shipping PVE-related perl
> code as activating the explicit trigger. the explicit trigger can
> still be used for packages that need to reload the API without
> shipping a perl module

> the explicit trigger activation can be dropped in PVE 9.0 in
> packages that ship perl code, without a need for versioned
> dependencies.

Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
---

If we expect the package to stop shipping Perl code at some point,
maybe it is better to just keep it?

 debian/pve-firewall.triggers | 1 -
 1 file changed, 1 deletion(-)

diff --git a/debian/pve-firewall.triggers b/debian/pve-firewall.triggers
index ea8e9e2..4294b34 100644
--- a/debian/pve-firewall.triggers
+++ b/debian/pve-firewall.triggers
@@ -1,2 +1 @@
-activate-noawait pve-api-updates
 interest-noawait /usr/share/perl5/PVE
-- 
2.47.3





      parent reply	other threads:[~2026-03-11 10:55 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-11 10:54 [RFC firewall 0/3] add triggers for PVE perl code updates Fiona Ebner
2026-03-11 10:54 ` [RFC firewall 1/3] d/postinst: handled triggers by reloading service Fiona Ebner
2026-03-11 10:54 ` [RFC firewall 2/3] d/pve-firewall.triggers: add interest in PVE perl code updates Fiona Ebner
2026-03-11 10:54 ` Fiona Ebner [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260311105524.50117-4-f.ebner@proxmox.com \
    --to=f.ebner@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal