From: Fiona Ebner <f.ebner@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [RFC firewall 0/3] add triggers for PVE perl code updates
Date: Wed, 11 Mar 2026 11:54:23 +0100 [thread overview]
Message-ID: <20260311105524.50117-1-f.ebner@proxmox.com> (raw)
Similar to the services shipped by pve-manager, the firewall service
should also be reloaded when Perl packages like libpve-common-perl or
libpve-network-perl are updated. There are false positives too, like
libpve-storage-perl, and avoiding theses would require a new trigger
name specifically for firewall and activating that new trigger in all
its dependencies. But maybe that one is the better way? Happy to hear
opinions :)
A path-based interest is chosen following the same rationale as
pve-manager commit 27d1db3a ("triggers: add path-based trigger
interest").
Note that this is not prompted by an actual issue I encountered, but
I did notice it when the firewall was still running with some manually
added logging in Daemon.pm even after reinstalling pve-common. I was
surprised and I felt like it's worth discussing whether we want any
triggers for the firewall service.
pve-firewall:
Fiona Ebner (3):
d/postinst: handled triggers by reloading service
d/pve-firewall.triggers: add interest in PVE perl code updates
d/pve-firewall.triggers: drop superfluous pve-api-updates activation
debian/postinst | 4 ++++
debian/pve-firewall.triggers | 2 +-
2 files changed, 5 insertions(+), 1 deletion(-)
Summary over all repositories:
2 files changed, 5 insertions(+), 1 deletions(-)
--
Generated by git-murpp 0.5.0
next reply other threads:[~2026-03-11 10:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-11 10:54 Fiona Ebner [this message]
2026-03-11 10:54 ` [RFC firewall 1/3] d/postinst: handled triggers by reloading service Fiona Ebner
2026-03-11 10:54 ` [RFC firewall 2/3] d/pve-firewall.triggers: add interest in PVE perl code updates Fiona Ebner
2026-03-11 10:54 ` [RFC firewall 3/3] d/pve-firewall.triggers: drop superfluous pve-api-updates activation Fiona Ebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260311105524.50117-1-f.ebner@proxmox.com \
--to=f.ebner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox