From: Fiona Ebner <f.ebner@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [PATCH storage v2 02/11] plugin: volume snapshot info: also return virtual size
Date: Wed, 11 Mar 2026 10:44:41 +0100 [thread overview]
Message-ID: <20260311094506.22359-3-f.ebner@proxmox.com> (raw)
In-Reply-To: <20260311094506.22359-1-f.ebner@proxmox.com>
For LVM storages using 'snapshot-as-volume-chain', it's necessary to
check that the size for the LV of the target snapshot volume is large
enough before doing a commit operation. Returning the virtual size of
the volume at the time the snapshot was taken in the result of
volume_snapshot_info() makes this easy to check.
Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
---
src/PVE/Storage/LVMPlugin.pm | 1 +
src/PVE/Storage/Plugin.pm | 3 +++
2 files changed, 4 insertions(+)
diff --git a/src/PVE/Storage/LVMPlugin.pm b/src/PVE/Storage/LVMPlugin.pm
index 32a8339..97c6b0a 100644
--- a/src/PVE/Storage/LVMPlugin.pm
+++ b/src/PVE/Storage/LVMPlugin.pm
@@ -909,6 +909,7 @@ sub volume_snapshot_info {
$info->{$snapname}->{file} = $snapfile;
$info->{$snapname}->{volname} = "$snapvolname";
$info->{$snapname}->{volid} = "$storeid:$snapvolname";
+ $info->{$snapname}->{'virtual-size'} = $snap->{'virtual-size'};
my $parentfile = $snap->{'backing-filename'};
if ($parentfile) {
diff --git a/src/PVE/Storage/Plugin.pm b/src/PVE/Storage/Plugin.pm
index d901853..ffe9464 100644
--- a/src/PVE/Storage/Plugin.pm
+++ b/src/PVE/Storage/Plugin.pm
@@ -1834,6 +1834,8 @@ Required values are:
=item C<volid>: The volume ID of the external snapshot volume.
+=item C<virtual-size>: The virtual size of the volume recorded by the snapshot.
+
=item C<child>: The name of the child snapshot in the volume chain. Not set if there is no child.
=item C<parent>: The name of the parent snapshot in the volume chain. Not set if there is no parent.
@@ -1913,6 +1915,7 @@ sub volume_snapshot_info {
$info->{$snapname}->{file} = $snapfile;
$info->{$snapname}->{volname} = "$snapvolname";
$info->{$snapname}->{volid} = "$storeid:$snapvolname";
+ $info->{$snapname}->{'virtual-size'} = $snap->{'virtual-size'};
$info->{$snapname}->{ext} = 1;
my $parentfile = $snap->{'backing-filename'};
--
2.47.3
next prev parent reply other threads:[~2026-03-11 9:46 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-11 9:44 [PATCH-SERIES storage/qemu-server v2 00/11] fix #7094: external snapshot delete: ensure commit target is large enough Fiona Ebner
2026-03-11 9:44 ` [PATCH storage v2 01/11] plugin: document volume_snapshot_info() method Fiona Ebner
2026-03-11 9:44 ` Fiona Ebner [this message]
2026-03-11 9:44 ` [PATCH storage v2 03/11] plugin: document volume_resize() method Fiona Ebner
2026-03-11 9:44 ` [PATCH storage v2 04/11] plugin/storage: volume resize: add snapname parameter Fiona Ebner
2026-03-11 9:44 ` [PATCH storage v2 05/11] lvm plugin: snapshot delete: clarify comment about using commit Fiona Ebner
2026-03-11 9:44 ` [PATCH storage v2 06/11] bump API age and version Fiona Ebner
2026-03-11 9:44 ` [PATCH storage v2 07/11] partially fix #7094: lvm: snapshot delete: ensure commit target is large enough Fiona Ebner
2026-03-11 9:44 ` [PATCH storage v2 08/11] plugin: volume snapshot info: don't set 'order' for internal snapshots Fiona Ebner
2026-03-11 9:44 ` [PATCH storage v2 09/11] plugin: volume snapshot info: correctly return internal snapshot information Fiona Ebner
2026-03-11 9:44 ` [PATCH storage v2 10/11] plugin: volume snapshot info: do not set 'ext' property Fiona Ebner
2026-03-11 9:44 ` [PATCH qemu-server v2 11/11] partially fix #7094: external snapshot delete: ensure commit target is large enough Fiona Ebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260311094506.22359-3-f.ebner@proxmox.com \
--to=f.ebner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox