From: Fiona Ebner <f.ebner@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [PATCH qemu-server v2 11/11] partially fix #7094: external snapshot delete: ensure commit target is large enough
Date: Wed, 11 Mar 2026 10:44:50 +0100 [thread overview]
Message-ID: <20260311094506.22359-12-f.ebner@proxmox.com> (raw)
In-Reply-To: <20260311094506.22359-1-f.ebner@proxmox.com>
For LVM storages using 'snapshot-as-volume-chain', it's necessary to
ensure that the size for the LV of the target snapshot volume is large
enough before doing a commit operation. Note that the change here also
affects file-based storages; previously resize would happen as part of
the commit operation automatically for them. This fixes the online
case.
Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
---
Dependency bump from qemu-server to libpve-storage-perl needed!
src/PVE/QemuServer.pm | 9 +++++++++
1 file changed, 9 insertions(+)
diff --git a/src/PVE/QemuServer.pm b/src/PVE/QemuServer.pm
index 09e7a19b..f99560a6 100644
--- a/src/PVE/QemuServer.pm
+++ b/src/PVE/QemuServer.pm
@@ -4414,6 +4414,15 @@ sub qemu_volume_snapshot_delete {
# improve-me: if firstsnap > child : commit, if firstsnap < child do a stream.
if (!$parentsnap) {
print "delete first snapshot $snap\n";
+
+ my $snap_size = $snapshots->{$snap}->{'virtual-size'};
+ my $child_size = $snapshots->{$childsnap}->{'virtual-size'};
+ if (defined($child_size) && defined($snap_size) && $child_size > $snap_size) {
+ print
+ "resize '$snap' ($snap_size bytes) to match '$childsnap' ($child_size bytes)\n";
+ PVE::Storage::volume_resize($storecfg, $volid, $child_size, $running, $snap);
+ }
+
PVE::QemuServer::VolumeChain::blockdev_commit(
$storecfg,
$vmid,
--
2.47.3
prev parent reply other threads:[~2026-03-11 9:46 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-11 9:44 [PATCH-SERIES storage/qemu-server v2 00/11] " Fiona Ebner
2026-03-11 9:44 ` [PATCH storage v2 01/11] plugin: document volume_snapshot_info() method Fiona Ebner
2026-03-11 9:44 ` [PATCH storage v2 02/11] plugin: volume snapshot info: also return virtual size Fiona Ebner
2026-03-11 9:44 ` [PATCH storage v2 03/11] plugin: document volume_resize() method Fiona Ebner
2026-03-11 9:44 ` [PATCH storage v2 04/11] plugin/storage: volume resize: add snapname parameter Fiona Ebner
2026-03-11 9:44 ` [PATCH storage v2 05/11] lvm plugin: snapshot delete: clarify comment about using commit Fiona Ebner
2026-03-11 9:44 ` [PATCH storage v2 06/11] bump API age and version Fiona Ebner
2026-03-11 9:44 ` [PATCH storage v2 07/11] partially fix #7094: lvm: snapshot delete: ensure commit target is large enough Fiona Ebner
2026-03-11 9:44 ` [PATCH storage v2 08/11] plugin: volume snapshot info: don't set 'order' for internal snapshots Fiona Ebner
2026-03-11 9:44 ` [PATCH storage v2 09/11] plugin: volume snapshot info: correctly return internal snapshot information Fiona Ebner
2026-03-11 9:44 ` [PATCH storage v2 10/11] plugin: volume snapshot info: do not set 'ext' property Fiona Ebner
2026-03-11 9:44 ` Fiona Ebner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260311094506.22359-12-f.ebner@proxmox.com \
--to=f.ebner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox