[PATCH manager/backup/datacenter-manager 0/3] report: adapt to zarcstat renaming

[PATCH manager/backup/datacenter-manager 0/3] report: adapt to zarcstat renaming

[Stoiko Ivanov]

Friedrich stumbled across the renaming of arcstat to zarcstat introduced
with ZFS 2.4.0 and reminded me of the inclusion of the output in our
support reports.

the following patchset simply adapts the command name in our report
utilities.

note that pmg-system-report (pmg-api) does not include the (z)arcstat
call in it's report.

All reports do still yield useful information even without the patch (but
of course the zarcstat output is missing for systems having zfsutils 2.4.0
or later).

Minimally tested on pve and pbs (by building an running
pvereport/proxmox-backup-manager report respectively).

pve-manager:
Stoiko Ivanov (1):
  report: adapt to zarcstat renaming

 PVE/Report.pm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

proxmox-backup:
Stoiko Ivanov (1):
  report: adapt to zarcstat renaming

 src/server/report.rs | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

proxmox-datacenter-manager:
Stoiko Ivanov (1):
  report: adapt to zarcstat renaming

 server/src/report.rs | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

-- 
2.47.3

[PATCH manager 1/3] report: adapt to zarcstat renaming

[Stoiko Ivanov]

With ZFS 2.4.0 `arcstat` was renamed to `zarcstat`, without providing
a symlink for backward compatibility [0].

This patch fixes the invocation in pvereport.

[0] https://git.proxmox.com/?p=zfsonlinux.git;a=commit;h=b52bb3caa4e4c7fab516c3aa828caa7b48b5ed7f

Reported-by: Friedrich Weber <f.weber@proxmox.com>
Signed-off-by: Stoiko Ivanov <s.ivanov@proxmox.com>
---
 PVE/Report.pm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/PVE/Report.pm b/PVE/Report.pm
index 549a5d23..29433d4a 100644
--- a/PVE/Report.pm
+++ b/PVE/Report.pm
@@ -147,7 +147,7 @@ my $init_report_cmds = sub {
             'zpool status',
             'zpool list -v',
             'zfs list',
-            'arcstat',
+            'zarcstat',
             ;
     }
 
-- 
2.47.3

[PATCH proxmox-backup 2/3] report: adapt to zarcstat renaming

[Stoiko Ivanov]

With ZFS 2.4.0 `arcstat` was renamed to `zarcstat`, without providing
a symlink for backward compatibility [0].

This patch fixes the invocation in proxmox-backup-manager report.

[0] https://git.proxmox.com/?p=zfsonlinux.git;a=commit;h=b52bb3caa4e4c7fab516c3aa828caa7b48b5ed7f

Reported-by: Friedrich Weber <f.weber@proxmox.com>
Signed-off-by: Stoiko Ivanov <s.ivanov@proxmox.com>
---
 src/server/report.rs | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/server/report.rs b/src/server/report.rs
index 546555fb..e4c761cd 100644
--- a/src/server/report.rs
+++ b/src/server/report.rs
@@ -85,7 +85,7 @@ fn commands() -> Vec<(&'static str, Vec<&'static str>)> {
         ("bash", vec!["-c", "ls -l /dev/disk/by-*/"]),
         ("zpool", vec!["status"]),
         ("zfs", vec!["list"]),
-        ("arcstat", vec![]),
+        ("zarcstat", vec![]),
         ("dmidecode", vec!["-t", "bios"]),
         ("lscpu", vec![]),
         ("lspci", vec!["-nnk"]),
-- 
2.47.3

[PATCH proxmox-datacenter-manager 3/3] report: adapt to zarcstat renaming

[Stoiko Ivanov]

With ZFS 2.4.0 `arcstat` was renamed to `zarcstat`, without providing
a symlink for backward compatibility [0].

This patch fixes the invocation in
proxmox-datacenter-manager-admin report.

[0] https://git.proxmox.com/?p=zfsonlinux.git;a=commit;h=b52bb3caa4e4c7fab516c3aa828caa7b48b5ed7f

Reported-by: Friedrich Weber <f.weber@proxmox.com>
Signed-off-by: Stoiko Ivanov <s.ivanov@proxmox.com>
---
 server/src/report.rs | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/server/src/report.rs b/server/src/report.rs
index 9da6b42..371d8cf 100644
--- a/server/src/report.rs
+++ b/server/src/report.rs
@@ -77,7 +77,7 @@ fn commands() -> Vec<(&'static str, Vec<&'static str>)> {
         ("ls", vec!["-l", "/dev/disk/by-id", "/dev/disk/by-path"]),
         ("zpool", vec!["status"]),
         ("zfs", vec!["list"]),
-        ("arcstat", vec![]),
+        ("zarcstat", vec![]),
         ("ip", vec!["-details", "-statistics", "address"]),
         ("ip", vec!["-4", "route", "show"]),
         ("ip", vec!["-6", "route", "show"]),
-- 
2.47.3