public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Fiona Ebner <f.ebner@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [RFC common/cluster v4 0/5] cluster files: support registering UTF-8 configuration file
Date: Tue, 10 Mar 2026 11:13:29 +0100	[thread overview]
Message-ID: <20260310101631.32870-1-f.ebner@proxmox.com> (raw)

Changes in v4:
* rather than searching for wide characters, tell parse_config()
  directly whether the file was registered as UTF-8

Changes in v3:
* rebase on current master.
* add patch to use strict UTF-8 encoding when writing.
* use strict UTF-8 for {de,en}coding in the rest of the series.
* let cfs_register_file() take an $options parameter rather than
  an $utf8 parameter, so future call sites are more readable.

Changes in v2:
* rebase on current master.
* use qw(encode) when importing Encode module.

A configuration file registered as UTF-8 will be automatically decoded
from UTF-8 to Perl's internal string format after reading and encoded
in the other direction before writing.

Patch 1/5 also makes sense without the rest of the RFC.

Note that patch 4/5 (required by 3/5) is a versioned breaks for
libpve-access-control which still needs to be bumped! Could be avoided
by keeping the implicit return of cfs_register_file(), but that's bad
for encapsulation.

Versioned dependency bump pve-cluster -> pve-common needed!

common:

Fiona Ebner (2):
  file: set contents: use strict UTF-8 encoding with $force_utf8
  section config: prepare for supporting UTF-8 encoded configurations

 src/PVE/File.pm          |  2 +-
 src/PVE/SectionConfig.pm | 29 ++++++++++++++++++++++++-----
 2 files changed, 25 insertions(+), 6 deletions(-)


cluster:

Fiona Ebner (3):
  cfs register file: avoid implicit return
  d/control: add versioned breaks for libpve-access-control
  cluster files: support registering UTF-8 configuration file

 debian/control     |  2 +-
 src/PVE/Cluster.pm | 20 ++++++++++++++++----
 2 files changed, 17 insertions(+), 5 deletions(-)


Summary over all repositories:
  4 files changed, 42 insertions(+), 11 deletions(-)

-- 
Generated by git-murpp 0.5.0




             reply	other threads:[~2026-03-10 10:17 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-10 10:13 Fiona Ebner [this message]
2026-03-10 10:13 ` [PATCH common v4 1/5] file: set contents: use strict UTF-8 encoding with $force_utf8 Fiona Ebner
2026-03-10 10:13 ` [PATCH common v4 2/5] section config: prepare for supporting UTF-8 encoded configurations Fiona Ebner
2026-03-10 10:13 ` [PATCH cluster v4 3/5] cfs register file: avoid implicit return Fiona Ebner
2026-03-10 10:13 ` [PATCH cluster v4 4/5] d/control: add versioned breaks for libpve-access-control Fiona Ebner
2026-03-10 10:13 ` [PATCH cluster v4 5/5] cluster files: support registering UTF-8 configuration file Fiona Ebner
2026-03-10 10:40   ` Hannes Laimer
2026-03-10 11:01     ` Fiona Ebner
2026-03-10 11:47       ` Hannes Laimer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260310101631.32870-1-f.ebner@proxmox.com \
    --to=f.ebner@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal