public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Dominik Csapak <d.csapak@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [PATCH manager] fix #7386: ui: make memory window compatible with older browsers again
Date: Tue, 10 Mar 2026 10:10:42 +0100	[thread overview]
Message-ID: <20260310091141.814416-1-d.csapak@proxmox.com> (raw)

while this is supported in most modern browsers, it's not supported in
(still updated) older Firefox ESR versions.

This was introduced in ECMAscript version 2025, which is against our
style guide that suggests we should stick to ES 2024 features for
trixie.

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
Usually I'd not go back with such things, but since it's just a one line
fix and technically the code was against our style guide, i think it's
fine.


 www/manager6/qemu/MemoryEdit.js | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/www/manager6/qemu/MemoryEdit.js b/www/manager6/qemu/MemoryEdit.js
index ff4a7545..0f6bd656 100644
--- a/www/manager6/qemu/MemoryEdit.js
+++ b/www/manager6/qemu/MemoryEdit.js
@@ -65,7 +65,7 @@ Ext.define('PVE.qemu.MemoryInputPanel', {
         }
 
         if (deleteSet.size > 0) {
-            res.delete = deleteSet.keys().toArray().join(',');
+            res.delete = Array.from(deleteSet.keys()).join(',');
         }
 
         return res;
-- 
2.47.3





             reply	other threads:[~2026-03-10  9:11 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-10  9:10 Dominik Csapak [this message]
2026-03-10 11:42 ` applied: " Thomas Lamprecht

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260310091141.814416-1-d.csapak@proxmox.com \
    --to=d.csapak@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal