From: Fiona Ebner <f.ebner@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [PATCH qemu-server v2 10/18] blockdev: switch blockdev_external_snapshot() to use QMP peer
Date: Mon, 9 Mar 2026 17:58:36 +0100 [thread overview]
Message-ID: <20260309165913.219308-11-f.ebner@proxmox.com> (raw)
In-Reply-To: <20260309165913.219308-1-f.ebner@proxmox.com>
Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
---
src/PVE/QemuServer.pm | 8 +++++++-
src/PVE/QemuServer/VolumeChain.pm | 10 +++++-----
2 files changed, 12 insertions(+), 6 deletions(-)
diff --git a/src/PVE/QemuServer.pm b/src/PVE/QemuServer.pm
index ddeb394c..3c698c4c 100644
--- a/src/PVE/QemuServer.pm
+++ b/src/PVE/QemuServer.pm
@@ -4356,7 +4356,13 @@ sub qemu_volume_snapshot {
my $snapshots = PVE::Storage::volume_snapshot_info($storecfg, $volid);
my $parent_snap = $snapshots->{'current'}->{parent};
PVE::QemuServer::VolumeChain::blockdev_external_snapshot(
- $storecfg, $vmid, $machine_version, $deviceid, $drive, $snap, $parent_snap,
+ $storecfg,
+ vm_qmp_peer($vmid),
+ $machine_version,
+ $deviceid,
+ $drive,
+ $snap,
+ $parent_snap,
);
} elsif ($do_snapshots_type eq 'storage') {
PVE::Storage::volume_snapshot($storecfg, $volid, $snap);
diff --git a/src/PVE/QemuServer/VolumeChain.pm b/src/PVE/QemuServer/VolumeChain.pm
index 01c5dd9b..8c0749de 100644
--- a/src/PVE/QemuServer/VolumeChain.pm
+++ b/src/PVE/QemuServer/VolumeChain.pm
@@ -14,7 +14,7 @@ use PVE::QemuServer::Drive;
use PVE::QemuServer::Monitor qw(mon_cmd qmp_cmd vm_qmp_peer);
sub blockdev_external_snapshot {
- my ($storecfg, $vmid, $machine_version, $deviceid, $drive, $snap, $parent_snap) = @_;
+ my ($storecfg, $qmp_peer, $machine_version, $deviceid, $drive, $snap, $parent_snap) = @_;
print "Creating a new current volume with $snap as backing snap\n";
@@ -26,7 +26,7 @@ sub blockdev_external_snapshot {
#reopen current to snap
blockdev_replace(
$storecfg,
- vm_qmp_peer($vmid),
+ $qmp_peer,
$machine_version,
$deviceid,
$drive,
@@ -53,11 +53,11 @@ sub blockdev_external_snapshot {
#backing need to be forced to undef in blockdev, to avoid reopen of backing-file on blockdev-add
$new_fmt_blockdev->{backing} = undef;
- mon_cmd($vmid, 'blockdev-add', %$new_fmt_blockdev);
+ qmp_cmd($qmp_peer, 'blockdev-add', %$new_fmt_blockdev);
print "blockdev-snapshot: reopen current with $snap backing image\n";
- mon_cmd(
- $vmid, 'blockdev-snapshot',
+ qmp_cmd(
+ $qmp_peer, 'blockdev-snapshot',
node => $snap_fmt_blockdev->{'node-name'},
overlay => $new_fmt_blockdev->{'node-name'},
);
--
2.47.3
next prev parent reply other threads:[~2026-03-09 17:01 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-09 16:58 [PATCH-SERIES qemu-server v2 00/18] fix #7066: api: allow live snapshot (remove) of qcow2 TPM drive with snapshot-as-volume-chain Fiona Ebner
2026-03-09 16:58 ` [PATCH qemu-server v2 01/18] block job: fix variable name in documentation Fiona Ebner
2026-03-09 16:58 ` [PATCH qemu-server v2 02/18] qmp client: add default timeouts for more block commands Fiona Ebner
2026-03-09 16:58 ` [PATCH qemu-server v2 03/18] drive: introduce drive_uses_qsd_fuse() helper Fiona Ebner
2026-03-09 16:58 ` [PATCH qemu-server v2 04/18] monitor: add vm_qmp_peer() helper Fiona Ebner
2026-03-09 16:58 ` [PATCH qemu-server v2 05/18] monitor: add qsd_peer() helper Fiona Ebner
2026-03-09 16:58 ` [PATCH qemu-server v2 06/18] blockdev: rename variable in get_node_name_below_throttle() for readability Fiona Ebner
2026-03-09 16:58 ` [PATCH qemu-server v2 07/18] blockdev: switch get_node_name_below_throttle() to use QMP peer Fiona Ebner
2026-03-09 16:58 ` [PATCH qemu-server v2 08/18] blockdev: switch detach() " Fiona Ebner
2026-03-09 16:58 ` [PATCH qemu-server v2 09/18] blockdev: switch blockdev_replace() " Fiona Ebner
2026-03-09 16:58 ` Fiona Ebner [this message]
2026-03-09 16:58 ` [PATCH qemu-server v2 11/18] block job: switch qemu_handle_concluded_blockjob() " Fiona Ebner
2026-03-09 16:58 ` [PATCH qemu-server v2 12/18] block job: switch qemu_blockjobs_cancel() " Fiona Ebner
2026-03-09 16:58 ` [PATCH qemu-server v2 13/18] block job: switch qemu_drive_mirror_monitor() " Fiona Ebner
2026-03-09 16:58 ` [PATCH qemu-server v2 14/18] blockdev: switch blockdev_delete() " Fiona Ebner
2026-03-09 16:58 ` [PATCH qemu-server v2 15/18] blockdev: switch blockdev_stream() " Fiona Ebner
2026-03-09 16:58 ` [PATCH qemu-server v2 16/18] blockdev: switch blockdev_commit() " Fiona Ebner
2026-03-09 16:58 ` [PATCH qemu-server v2 17/18] snapshot: support live snapshot (remove) of qcow2 TPM drive on storage with snapshot-as-volume-chain Fiona Ebner
2026-03-09 16:58 ` [PATCH qemu-server v2 18/18] fix #7066: api: allow live snapshot (remove) of qcow2 TPM drive " Fiona Ebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260309165913.219308-11-f.ebner@proxmox.com \
--to=f.ebner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox