public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Fiona Ebner <f.ebner@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [PATCH common v3 2/5] section config: prepare for supporting UTF-8 encoded configurations
Date: Mon,  9 Mar 2026 16:42:23 +0100	[thread overview]
Message-ID: <20260309154344.165878-3-f.ebner@proxmox.com> (raw)
In-Reply-To: <20260309154344.165878-1-f.ebner@proxmox.com>

Configurations registered as UTF-8 will be decoded after reading to
Perl's internal string format and then contain wide characters. The
Digest::SHA::sha1_hex() function croaks on wide characters, so encode
again before calling the function if there are wide characters.

Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
---

Changes in v3:
* use strict 'UTF-8' encoding.

 src/PVE/SectionConfig.pm | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/PVE/SectionConfig.pm b/src/PVE/SectionConfig.pm
index 84ff81a..ed5a632 100644
--- a/src/PVE/SectionConfig.pm
+++ b/src/PVE/SectionConfig.pm
@@ -103,6 +103,7 @@ use warnings;
 
 use Carp;
 use Digest::SHA;
+use Encode qw(encode);
 
 use PVE::Exception qw(raise_param_exc);
 use PVE::JSONSchema qw(get_standard_option);
@@ -1214,7 +1215,11 @@ sub parse_config {
 
     $raw = '' if !defined($raw);
 
-    my $digest = Digest::SHA::sha1_hex($raw);
+    my $bytes = $raw;
+    # Digest::SHA croaks on wide characters
+    $bytes = encode('UTF-8', $raw) if $raw =~ /[^\x00-\xFF]/;
+
+    my $digest = Digest::SHA::sha1_hex($bytes);
 
     my $pri = 1;
 
-- 
2.47.3





  parent reply	other threads:[~2026-03-09 15:44 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-09 15:42 [RFC common/cluster v3 0/5] cluster files: support registering UTF-8 configuration file Fiona Ebner
2026-03-09 15:42 ` [PATCH common v3 1/5] file: set contents: use strict UTF-8 encoding with $force_utf8 Fiona Ebner
2026-03-09 15:42 ` Fiona Ebner [this message]
2026-03-10  8:40   ` [PATCH common v3 2/5] section config: prepare for supporting UTF-8 encoded configurations Dominik Csapak
2026-03-10  9:18     ` Fiona Ebner
2026-03-10  9:23       ` Dominik Csapak
2026-03-09 15:42 ` [PATCH cluster v3 3/5] cfs register file: avoid implicit return Fiona Ebner
2026-03-09 15:42 ` [PATCH cluster v3 4/5] d/control: add versioned breaks for libpve-access-control Fiona Ebner
2026-03-09 15:42 ` [PATCH cluster v3 5/5] cluster files: support registering UTF-8 configuration file Fiona Ebner
2026-03-10 10:18 ` superseded: [RFC common/cluster v3 0/5] " Fiona Ebner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260309154344.165878-3-f.ebner@proxmox.com \
    --to=f.ebner@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal