From: Dominik Csapak <d.csapak@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [PATCH manager v3 16/18] ui: qemu: make processor edit architecture aware
Date: Mon, 2 Mar 2026 14:21:04 +0100 [thread overview]
Message-ID: <20260302132913.3169037-17-d.csapak@proxmox.com> (raw)
In-Reply-To: <20260302132913.3169037-1-d.csapak@proxmox.com>
The cpu and flags list we get from the backend got an architecture
parameter that we now use to filter the correct cpu models.
For the flags grid, we add an emptyText to show when there are no flags
available (e.g. currently this is the case for aarch64).
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
www/manager6/form/CPUModelSelector.js | 13 +++++++++++++
www/manager6/form/VMCPUFlagSelector.js | 13 +++++++++++++
www/manager6/qemu/CreateWizard.js | 3 +++
www/manager6/qemu/ProcessorEdit.js | 19 +++++++++++++++++++
4 files changed, 48 insertions(+)
diff --git a/www/manager6/form/CPUModelSelector.js b/www/manager6/form/CPUModelSelector.js
index 2ebd08eb..602706e7 100644
--- a/www/manager6/form/CPUModelSelector.js
+++ b/www/manager6/form/CPUModelSelector.js
@@ -40,6 +40,19 @@ Ext.define('PVE.form.CPUModelSelector', {
width: 360,
},
+ arch: undefined,
+
+ setArch: function (arch) {
+ let me = this;
+ me.arch = arch;
+ let params = {};
+ if (arch) {
+ params.arch = arch;
+ }
+ me.store.getProxy().setExtraParams(params);
+ me.store.reload();
+ },
+
store: {
autoLoad: true,
model: 'PVE.data.CPUModel',
diff --git a/www/manager6/form/VMCPUFlagSelector.js b/www/manager6/form/VMCPUFlagSelector.js
index 922fcfa6..6e49ea45 100644
--- a/www/manager6/form/VMCPUFlagSelector.js
+++ b/www/manager6/form/VMCPUFlagSelector.js
@@ -16,6 +16,8 @@ Ext.define('PVE.form.VMCPUFlagSelector', {
unkownFlags: [],
+ emptyText: gettext('No CPU flags available'),
+
store: {
type: 'store',
fields: ['name', { name: 'state', defaultValue: '=' }, 'description'],
@@ -67,6 +69,17 @@ Ext.define('PVE.form.VMCPUFlagSelector', {
return flags;
},
+ setArch: function (arch) {
+ let me = this;
+ me.arch = arch;
+ let params = {};
+ if (arch) {
+ params.arch = arch;
+ }
+ me.store.getProxy().setExtraParams(params);
+ me.store.reload();
+ },
+
// Adjusts the store for the current value and determines the unkown flags based on what the
// store does not know.
adjustStoreForValue: function () {
diff --git a/www/manager6/qemu/CreateWizard.js b/www/manager6/qemu/CreateWizard.js
index 06760230..ea27c5ef 100644
--- a/www/manager6/qemu/CreateWizard.js
+++ b/www/manager6/qemu/CreateWizard.js
@@ -246,6 +246,9 @@ Ext.define('PVE.qemu.CreateWizard', {
xtype: 'pveQemuProcessorPanel',
insideWizard: true,
title: gettext('CPU'),
+ bind: {
+ arch: '{current.architecture}',
+ },
},
{
xtype: 'pveQemuMemoryPanel',
diff --git a/www/manager6/qemu/ProcessorEdit.js b/www/manager6/qemu/ProcessorEdit.js
index ffaf014e..5fa57048 100644
--- a/www/manager6/qemu/ProcessorEdit.js
+++ b/www/manager6/qemu/ProcessorEdit.js
@@ -108,6 +108,15 @@ Ext.define('PVE.qemu.ProcessorInputPanel', {
cpu: {},
+ arch: undefined,
+
+ setArch: function (arch) {
+ let me = this;
+ me.arch = arch;
+ me.lookup('cputype').setArch(arch);
+ me.lookup('cpuFlags').setArch(arch);
+ },
+
column1: [
{
xtype: 'proxmoxintegerfield',
@@ -236,10 +245,12 @@ Ext.define('PVE.qemu.ProcessorInputPanel', {
advancedColumnB: [
{
xtype: 'label',
+ reference: 'cpuFlagsLabel',
text: 'Extra CPU Flags:',
},
{
xtype: 'vmcpuflagselector',
+ reference: 'cpuFlags',
name: 'flags',
},
],
@@ -259,6 +270,12 @@ Ext.define('PVE.qemu.ProcessorEdit', {
initComponent: function () {
let me = this;
+
+ me.nodename = me.pveSelNode?.data.node;
+ if (!me.nodename) {
+ throw 'no nodename given';
+ }
+
me.getViewModel().set('cgroupMode', me.cgroupMode);
var ipanel = Ext.create('PVE.qemu.ProcessorInputPanel');
@@ -289,6 +306,8 @@ Ext.define('PVE.qemu.ProcessorEdit', {
}
}
me.setValues(data);
+ let arch = PVE.qemu.Architecture.getGuestArchitecture(data.arch, me.nodename);
+ ipanel.setArch(arch);
},
});
},
--
2.47.3
next prev parent reply other threads:[~2026-03-02 13:29 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-02 13:20 [PATCH manager v3 00/18] enable qemu vm architecture selection Dominik Csapak
2026-03-02 13:20 ` [PATCH manager v3 01/18] api/pvestatd: broadcast and expose non-x86 host architecture Dominik Csapak
2026-03-02 13:20 ` [PATCH manager v3 02/18] ui: qemu: wizard: refactor ostype and cd selector into an OSPanel Dominik Csapak
2026-03-02 13:20 ` [PATCH manager v3 03/18] ui: form: add filtered KVComboBox Dominik Csapak
2026-03-02 13:20 ` [PATCH manager v3 04/18] ui: resource store: add architecture field Dominik Csapak
2026-03-02 13:20 ` [PATCH manager v3 05/18] ui: qemu: add architecture specific defaults and helpers Dominik Csapak
2026-03-02 13:20 ` [PATCH manager v3 06/18] ui: qemu: add architecture field in wizard and hardware view Dominik Csapak
2026-03-02 13:20 ` [PATCH manager v3 07/18] ui: qemu: make scsi hw selector architecture aware Dominik Csapak
2026-03-02 13:20 ` [PATCH manager v3 08/18] ui: qemu: make osdefaults " Dominik Csapak
2026-03-02 13:20 ` [PATCH manager v3 09/18] ui: qemu: make os type selector " Dominik Csapak
2026-03-02 13:20 ` [PATCH manager v3 10/18] ui: qemu: make machine panels/fields " Dominik Csapak
2026-03-02 13:20 ` [PATCH manager v3 11/18] ui: qemu: make bios selector " Dominik Csapak
2026-03-02 13:21 ` [PATCH manager v3 12/18] ui: qemu: make sortByPreviousUsage " Dominik Csapak
2026-03-02 13:21 ` [PATCH manager v3 13/18] ui: qemu: wizard: use defaults to populate machine and bios Dominik Csapak
2026-03-02 13:21 ` [PATCH manager v3 14/18] ui: qemu: wizard: make iso confid architecture specific Dominik Csapak
2026-03-02 13:21 ` [PATCH manager v3 15/18] ui: qemu: make bus selector architecture aware Dominik Csapak
2026-03-02 13:21 ` Dominik Csapak [this message]
2026-03-02 13:21 ` [PATCH manager v3 17/18] ui: qemu: change ui default for cpu model Dominik Csapak
2026-03-02 13:21 ` [PATCH manager v3 18/18] ui: qemu: set arch parameter for fetch machine types from api Dominik Csapak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260302132913.3169037-17-d.csapak@proxmox.com \
--to=d.csapak@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox